]> granicus.if.org Git - php/commitdiff
MFH: Fixed crash + leak
authorfoobar <sniper@php.net>
Thu, 30 Dec 2004 05:33:26 +0000 (05:33 +0000)
committerfoobar <sniper@php.net>
Thu, 30 Dec 2004 05:33:26 +0000 (05:33 +0000)
ext/imap/php_imap.c

index bfc557ebfac3bce11acf07d4c1221f43d5baba0c..9d7958ebba3967b167d8790ed0e98c664ebc6107 100644 (file)
@@ -2980,7 +2980,7 @@ PHP_FUNCTION(imap_mail_compose)
                        bod->contents.text.size = Z_STRLEN_PP(pvalue);
                } else {
                        bod->contents.text.data = (char *) fs_get(1);
-                       bod->contents.text.data = "";
+                       memcpy(bod->contents.text.data, "", 1);
                        bod->contents.text.size = 0;
                }
                if (zend_hash_find(Z_ARRVAL_PP(data), "lines", sizeof("lines"), (void **) &pvalue)== SUCCESS) {
@@ -3193,9 +3193,7 @@ PHP_FUNCTION(imap_mail_compose)
 
        RETVAL_STRING(tempstring, 0);  
 done:
-#if ilia_0 /* this should be done, otherwise we leak memory. Unfortunately this seems to cause a crash in some cases */
        mail_free_body(&topbod);
-#endif
        mail_free_envelope(&env);
 }
 /* }}} */