pam_echo: Avoid leaking file descriptor.

modules/pam_echo/pam_echo.c (pam_echo): Close fd in error cases.

diff --git a/modules/pam_echo/pam_echo.c b/modules/pam_echo/pam_echo.c
index 043ff7034d3d9e14c54bb95925853c7bac53bacc..d0879fbfe980645ebe302c8fc2de6402334d1883 100644 (file)
--- a/modules/pam_echo/pam_echo.c
+++ b/modules/pam_echo/pam_echo.c
@@ -180,16 +180,23 @@ pam_echo (pam_handle_t *pamh, int flags, int argc, const char **argv)
 
       /* load file into message buffer. */
       if ((fstat (fd, &st) < 0) || !st.st_size)
-       return PAM_IGNORE;
+       {
+         close (fd);
+         return PAM_IGNORE;
+       }
 
       mtmp = malloc (st.st_size + 1);
       if (!mtmp)
-       return PAM_BUF_ERR;
+       {
+         close (fd);
+         return PAM_BUF_ERR;
+       }
 
       if (pam_modutil_read (fd, mtmp, st.st_size) == -1)
        {
          pam_syslog (pamh, LOG_ERR, "Error while reading %s: %m", file);
          free (mtmp);
+         close (fd);
          return PAM_IGNORE;
        }