]> granicus.if.org Git - php/commitdiff
Use zend_string_equals() API instead of strcmp() in SOAP extension
authorGeorge Peter Banyard <girgias@php.net>
Wed, 17 Mar 2021 11:23:02 +0000 (11:23 +0000)
committerGeorge Peter Banyard <girgias@php.net>
Wed, 17 Mar 2021 16:36:16 +0000 (16:36 +0000)
ext/soap/php_http.c
ext/soap/soap.c

index b14c8cc1a10a7e17a81035c27fd07e09dbfffa2a..9119fee9a79f642a3d72447c412def1755b6bc71 100644 (file)
@@ -491,7 +491,7 @@ try_again:
                     (((use_ssl && orig->scheme != NULL && zend_string_equals_literal(orig->scheme, "https")) ||
                      (!use_ssl && orig->scheme == NULL) ||
                      (!use_ssl && !zend_string_equals_literal(orig->scheme, "https"))) &&
-                    strcmp(ZSTR_VAL(orig->host), ZSTR_VAL(phpurl->host)) == 0 &&
+                    zend_string_equals(orig->host, phpurl->host) &&
                     orig->port == phpurl->port))) {
     } else {
                        php_stream_close(stream);
index 49815082a83b53ba6e82efb6f6a7ed2a78067b87..b1423bc60a42020412df4c5cfddb8456baef5790 100644 (file)
@@ -1275,9 +1275,9 @@ PHP_METHOD(SoapServer, handle)
                            (encoding = zend_hash_str_find(Z_ARRVAL_P(server_vars), "HTTP_CONTENT_ENCODING", sizeof("HTTP_CONTENT_ENCODING")-1)) != NULL &&
                            Z_TYPE_P(encoding) == IS_STRING) {
 
-                               if (strcmp(Z_STRVAL_P(encoding),"gzip") == 0
-                               ||  strcmp(Z_STRVAL_P(encoding),"x-gzip") == 0
-                               ||  strcmp(Z_STRVAL_P(encoding),"deflate") == 0
+                               if (zend_string_equals_literal(Z_STR_P(encoding), "gzip")
+                                       || zend_string_equals_literal(Z_STR_P(encoding), "x-gzip")
+                                       || zend_string_equals_literal(Z_STR_P(encoding), "deflate")
                                ) {
                                        zval filter_params;