Issue #21311: Avoid exception in _osx_support with non-standard compiler

configurations.  Patch by John Szakmeister.

diff --git a/Lib/_osx_support.py b/Lib/_osx_support.py
index 5a0b71e9cacd2351e1acec1e8299ff3001435e78..d02b8856af0c74d87001cfd24cafda149ec79a09 100644 (file)
--- a/Lib/_osx_support.py
+++ b/Lib/_osx_support.py
@@ -182,7 +182,7 @@ def _find_appropriate_compiler(_config_vars):
         # Compiler is GCC, check if it is LLVM-GCC
         data = _read_output("'%s' --version"
                              % (cc.replace("'", "'\"'\"'"),))
-        if 'llvm-gcc' in data:
+        if data and 'llvm-gcc' in data:
             # Found LLVM-GCC, fall back to clang
             cc = _find_build_tool('clang')
 

diff --git a/Misc/ACKS b/Misc/ACKS
index 3af3ff401dae1ec5807b999fee2ac655d4d900e2..9a6f57adbd1080eede11be5728d6b2b0b1101d47 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1280,6 +1280,7 @@ Andrew Svetlov
 Paul Swartz
 Thenault Sylvain
 Péter Szabó
+John Szakmeister
 Amir Szekely
 Arfrever Frehtes Taifersar Arahesis
 Hideaki Takahashi

diff --git a/Misc/NEWS b/Misc/NEWS
index 4c0c3a67fabf9deab249ca9362b9bdce9e1c66bb..54546b444ed7dee6cc80616683ff33a460e21836 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -271,6 +271,9 @@ Library
   (Original patches by Hirokazu Yamamoto and Amaury Forgeot d'Arc, with
   suggested wording by David Gutteridge)
 
+- Issue #21311: Avoid exception in _osx_support with non-standard compiler
+  configurations.  Patch by John Szakmeister.
+
 Tools/Demos
 -----------