Fix ancient connection leak in dblink

When using unnamed connections with dblink, every time a new
connection is made, the old one is leaked. Fix that.

This has been an issue probably since dblink was first committed.
Someone complained almost ten years ago, but apparently I decided
not to pursue it at the time, and neither did anyone else, so it
slipped between the cracks. Now that someone else has complained,
fix in all supported branches.

Discussion: (orig) https://postgr.es/m/flat/F680AB59-6D6F-4026-9599-1BE28880273D%40decibel.org#F680AB59-6D6F-4026-9599-1BE28880273D@decibel.org
Discussion: (new) https://postgr.es/m/flat/0A3221C70F24FB45833433255569204D1F6ADF8C@G01JPEXMBYT05
Reported by: Jim Nasby and Takayuki Tsunakawa

diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index 5b041ddc7ce8c45bff1c33cc851c7e5b996c93c5..9528d33f4849db3c2eaf7407ee60a9c01cbeaf79 100644 (file)
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -301,7 +301,11 @@ dblink_connect(PG_FUNCTION_ARGS)
                createNewConnection(connname, rconn);
        }
        else
+       {
+               if (pconn->conn)
+                       PQfinish(pconn->conn);
                pconn->conn = conn;
+       }
 
        PG_RETURN_TEXT_P(cstring_to_text("OK"));
 }