]> granicus.if.org Git - icu/commitdiff
ICU-10640 Fix misspelled word in comments. Add TODO to revisit how we dtermine if...
authorTravis Keep <keep94@gmail.com>
Tue, 11 Mar 2014 23:33:52 +0000 (23:33 +0000)
committerTravis Keep <keep94@gmail.com>
Tue, 11 Mar 2014 23:33:52 +0000 (23:33 +0000)
X-SVN-Rev: 35421

icu4c/source/i18n/measfmt.cpp
icu4c/source/test/intltest/tufmtts.cpp

index a7387b03f630a351f290a3b6a3450b15df6636e8..2c567d20f2bd4c31e04e4cb19ac8d2331a7cea2e 100644 (file)
@@ -398,6 +398,9 @@ static int32_t toHMS(
     // We use copy constructor to ensure that both sides of equality operator
     // are instances of MeasureUnit base class and not a subclass. Otherwise,
     // operator== will immediately return false.
+    // TODO(Travis Keep): Propose
+    // UBool isUnitSame(const MeasureUnit &other) const to address performance
+    // issues around copy constructor.
     for (int32_t i = 0; i < measureCount; ++i) {
         if (MeasureUnit(measures[i].getUnit()) == *hourUnit) {
             // hour must come first
index 0851a82cc1dae74f8c299d63741694f19af9d202..20ffe253f27f064397dff584dd2835a47569b819 100644 (file)
@@ -139,7 +139,7 @@ void TimeUnitTest::testAPI() {
     TimeUnit::UTimeUnitFields field = tmunit_m->getTimeUnitField();
     assertTrue("field of month time unit is month", (field == TimeUnit::UTIMEUNIT_MONTH));
 
-    //===== Interopability with MeasureUnit ======
+    //===== Interoperability with MeasureUnit ======
     MeasureUnit **ptrs = new MeasureUnit *[TimeUnit::UTIMEUNIT_FIELD_COUNT];
 
     ptrs[TimeUnit::UTIMEUNIT_YEAR] = MeasureUnit::createYear(status);