]> granicus.if.org Git - python/commitdiff
Issue #8713: Cleanup before saving process._dangling.
authorRichard Oudkerk <shibturn@gmail.com>
Thu, 29 Aug 2013 11:51:11 +0000 (12:51 +0100)
committerRichard Oudkerk <shibturn@gmail.com>
Thu, 29 Aug 2013 11:51:11 +0000 (12:51 +0100)
Lib/test/regrtest.py

index fab1764836fab005e5f64f30b8f115f16c615552..03f168ebacd0b46ee660d79f283f411c0fccbf38 100755 (executable)
@@ -1010,8 +1010,10 @@ class saved_test_environment:
                  'os.environ', 'sys.path', 'sys.path_hooks', '__import__',
                  'warnings.filters', 'asyncore.socket_map',
                  'logging._handlers', 'logging._handlerList', 'sys.gettrace',
-                 'sys.warnoptions', 'threading._dangling',
-                 'multiprocessing.process._dangling',
+                 'sys.warnoptions',
+                 # multiprocessing.process._cleanup() may release ref
+                 # to a thread, so check processes first.
+                 'multiprocessing.process._dangling', 'threading._dangling',
                  'sysconfig._CONFIG_VARS', 'sysconfig._INSTALL_SCHEMES',
                  'support.TESTFN', 'locale', 'warnings.showwarning',
                 )
@@ -1141,6 +1143,8 @@ class saved_test_environment:
     def get_multiprocessing_process__dangling(self):
         if not multiprocessing:
             return None
+        # Unjoined process objects can survive after process exits
+        multiprocessing.process._cleanup()
         # This copies the weakrefs without making any strong reference
         return multiprocessing.process._dangling.copy()
     def restore_multiprocessing_process__dangling(self, saved):