Squashing
warning: ‘sym’ may be used uninitialized in this function
Here was no real usage of uninitialized variable, but
compiler still complains.
Pointer sym is allocated when flag with_val is set:
if (with_val) {
sym = agattr(g, AGEDGE, "len", "1");
}
So just squash the warning by setting the
pointer to NULL and test it in guard condition
instead of testing the flag:
if (sym && val) {
sprintf(buf, "%f", val[j]);
agxset(e, sym, buf);
}
agxbuf xb;
char buf[BUFS];
unsigned char string[BUFS];
- Agsym_t *sym, *sym2 = NULL, *sym3 = NULL;
+ Agsym_t *sym = NULL, *sym2 = NULL, *sym3 = NULL;
int *ia = A->ia;
int *ja = A->ja;
double *val = (double *) (A->a);
for (j = ia[i]; j < ia[i + 1]; j++) {
h = arr[ja[j]];
e = agedge(g, n, h, NULL, 1);
- if (with_val && val) {
+ if (sym && val) {
sprintf(buf, "%f", val[j]);
agxset(e, sym, buf);
}