DiagnosticsEngine::setMappingToAllDiagnostics() does not need to return bool,

caught by Chad.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@149173 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/clang/Basic/Diagnostic.h b/include/clang/Basic/Diagnostic.h
index c587a1d6e200fe0c291554cf49dfabb52852ee1e..3aa1d55c100b46a3f0f7f3ab778ea4b40615e6ab 100644 (file)
--- a/include/clang/Basic/Diagnostic.h
+++ b/include/clang/Basic/Diagnostic.h
@@ -479,7 +479,7 @@ public:
   /// \brief Add the specified mapping to all diagnostics. Mainly to be used
   /// by -Wno-everything to disable all warnings but allow subsequent -W options
   /// to enable specific warnings.
-  bool setMappingToAllDiagnostics(diag::Mapping Map,
+  void setMappingToAllDiagnostics(diag::Mapping Map,
                                   SourceLocation Loc = SourceLocation());
 
   bool hasErrorOccurred() const { return ErrorOccurred; }

diff --git a/lib/Basic/Diagnostic.cpp b/lib/Basic/Diagnostic.cpp
index eab79d6442d7b8ad6697960fa93f0558d072c3eb..369c32dc1215b642af88991acde66efacd460d2c 100644 (file)
--- a/lib/Basic/Diagnostic.cpp
+++ b/lib/Basic/Diagnostic.cpp
@@ -295,7 +295,7 @@ bool DiagnosticsEngine::setDiagnosticGroupErrorAsFatal(StringRef Group,
   return false;
 }
 
-bool DiagnosticsEngine::setMappingToAllDiagnostics(diag::Mapping Map,
+void DiagnosticsEngine::setMappingToAllDiagnostics(diag::Mapping Map,
                                                    SourceLocation Loc) {
   // Get all the diagnostics.
   llvm::SmallVector<diag::kind, 64> AllDiags;
@@ -305,8 +305,6 @@ bool DiagnosticsEngine::setMappingToAllDiagnostics(diag::Mapping Map,
   for (unsigned i = 0, e = AllDiags.size(); i != e; ++i)
     if (Diags->isBuiltinWarningOrExtension(AllDiags[i]))
       setDiagnosticMapping(AllDiags[i], Map, Loc);
-
-  return false;
 }
 
 void DiagnosticsEngine::Report(const StoredDiagnostic &storedDiag) {