Remove redundant logging of send failures when SSL is in use. While pqcomm.c

had been taught not to do that ages ago, the SSL code was helpfully bleating
anyway.  Resolves some recent reports such as bug #3266; however the
underlying cause of the related bug #2829 is still unclear.

diff --git a/src/backend/libpq/be-secure.c b/src/backend/libpq/be-secure.c
index 0ee0bc1c825be212ebf45ef5d52646fe274314e1..2ef6b4ac0b4b4fc650e701d3e3500beb13ae91f8 100644 (file)
--- a/src/backend/libpq/be-secure.c
+++ b/src/backend/libpq/be-secure.c
@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *       $Header: /cvsroot/pgsql/src/backend/libpq/be-secure.c,v 1.43.2.3 2006/05/12 22:44:58 tgl Exp $
+ *       $Header: /cvsroot/pgsql/src/backend/libpq/be-secure.c,v 1.43.2.4 2007/05/18 01:20:48 tgl Exp $
  *
  *       Since the server static private key ($DataDir/server.key)
  *       will normally be stored unencrypted so that the database
@@ -269,15 +269,9 @@ rloop:
                        case SSL_ERROR_WANT_WRITE:
                                goto rloop;
                        case SSL_ERROR_SYSCALL:
-                               if (n == -1)
-                                       ereport(COMMERROR,
-                                                       (errcode_for_socket_access(),
-                                                        errmsg("SSL SYSCALL error: %m")));
-                               else
+                               /* leave it to caller to ereport the value of errno */
+                               if (n != -1)
                                {
-                                       ereport(COMMERROR,
-                                                       (errcode(ERRCODE_PROTOCOL_VIOLATION),
-                                                        errmsg("SSL SYSCALL error: EOF detected")));
                                        errno = ECONNRESET;
                                        n = -1;
                                }
@@ -360,15 +354,9 @@ wloop:
                        case SSL_ERROR_WANT_WRITE:
                                goto wloop;
                        case SSL_ERROR_SYSCALL:
-                               if (n == -1)
-                                       ereport(COMMERROR,
-                                                       (errcode_for_socket_access(),
-                                                        errmsg("SSL SYSCALL error: %m")));
-                               else
+                               /* leave it to caller to ereport the value of errno */
+                               if (n != -1)
                                {
-                                       ereport(COMMERROR,
-                                                       (errcode(ERRCODE_PROTOCOL_VIOLATION),
-                                                        errmsg("SSL SYSCALL error: EOF detected")));
                                        errno = ECONNRESET;
                                        n = -1;
                                }