get_terminal_size() can also fail with ENOTTY if the fd is not connected to a terminal.

diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index b9eb2902b8aacd25e740bdc72497b409d7f13c98..c5dbb95629ca4d514a5ffc3f4814726feac0b29c 100644 (file)
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -1851,7 +1851,7 @@ class TermsizeTests(unittest.TestCase):
         try:
             size = os.get_terminal_size()
         except OSError as e:
-            if e.errno == errno.EINVAL or sys.platform == "win32":
+            if sys.platform == "win32" or e.errno in (errno.EINVAL, errno.ENOTTY):
                 # Under win32 a generic OSError can be thrown if the
                 # handle cannot be retrieved
                 self.skipTest("failed to query terminal size")
@@ -1873,7 +1873,14 @@ class TermsizeTests(unittest.TestCase):
             self.skipTest("stty invocation failed")
         expected = (int(size[1]), int(size[0])) # reversed order
 
-        actual = os.get_terminal_size(sys.__stdin__.fileno())
+        try:
+            actual = os.get_terminal_size(sys.__stdin__.fileno())
+        except OSError as e:
+            if sys.platform == "win32" or e.errno in (errno.EINVAL, errno.ENOTTY):
+                # Under win32 a generic OSError can be thrown if the
+                # handle cannot be retrieved
+                self.skipTest("failed to query terminal size")
+            raise
         self.assertEqual(expected, actual)