]> granicus.if.org Git - php/commitdiff
* Changed the way removed ini directives are shown so its easier to add new ones
authorKalle Sommer Nielsen <kalle@php.net>
Mon, 12 Apr 2010 01:52:55 +0000 (01:52 +0000)
committerKalle Sommer Nielsen <kalle@php.net>
Mon, 12 Apr 2010 01:52:55 +0000 (01:52 +0000)
* Removed define_syslog_variables and its associated functions

16 files changed:
Makefile.global
ext/standard/basic_functions.c
ext/standard/basic_functions.h
ext/standard/php_ext_syslog.h
ext/standard/syslog.c
ext/standard/tests/misc/syslog_vars_variation1.phpt [deleted file]
ext/standard/tests/misc/syslog_vars_variation2.phpt [deleted file]
ext/standard/tests/network/define_syslog_variables_basic-win32.phpt [deleted file]
ext/standard/tests/network/define_syslog_variables_basic.phpt [deleted file]
ext/standard/tests/network/define_syslog_variables_error.phpt [deleted file]
ext/standard/tests/network/define_syslog_variables_variation.phpt [deleted file]
ext/standard/tests/network/define_syslog_variables_variation2-win32.phpt [deleted file]
ext/standard/tests/network/define_syslog_variables_variation2.phpt [deleted file]
main/main.c
php.ini-development
php.ini-production

index 4f7d6d9e9b28ca8d0ae3e2db8e4f6b2bb516a95c..99d6c1c025c7c03296e4281b7659af39a6ce6dba 100644 (file)
@@ -79,7 +79,7 @@ PHP_TEST_SHARED_EXTENSIONS =  ` \
                        . $$i; $(top_srcdir)/build/shtool echo -n -- " -d $(ZEND_EXT_TYPE)=$(top_builddir)/modules/$$dlname"; \
                done; \
        fi`
-PHP_DEPRECATED_DIRECTIVES_REGEX = '^(define_syslog_variables|register_(globals|long_arrays)?|safe_mode|magic_quotes_(gpc|runtime|sybase)?|(zend_)?extension(_debug)?(_ts)?)[\t\ ]*='
+PHP_DEPRECATED_DIRECTIVES_REGEX = '^(register_(globals|long_arrays)?|safe_mode|magic_quotes_(gpc|runtime|sybase)?|(zend_)?extension(_debug)?(_ts)?)[\t\ ]*='
 
 test: all
        -@if test ! -z "$(PHP_EXECUTABLE)" && test -x "$(PHP_EXECUTABLE)"; then \
index 38c608f6701adc763ec320ce9cedcb2f3c059620..b3e8c70bbb1ebcfe5d55cb82ac64e5ef43e7a244 100644 (file)
@@ -2464,9 +2464,6 @@ ZEND_END_ARG_INFO()
 /* }}} */
 /* {{{ syslog.c */
 #ifdef HAVE_SYSLOG_H
-ZEND_BEGIN_ARG_INFO(arginfo_define_syslog_variables, 0)
-ZEND_END_ARG_INFO()
-
 ZEND_BEGIN_ARG_INFO(arginfo_openlog, 0)
        ZEND_ARG_INFO(0, ident)
        ZEND_ARG_INFO(0, option)
@@ -3221,7 +3218,6 @@ const zend_function_entry basic_functions[] = { /* {{{ */
        PHP_FE(openlog,                                                                                                                 arginfo_openlog)
        PHP_FE(syslog,                                                                                                                  arginfo_syslog)
        PHP_FE(closelog,                                                                                                                arginfo_closelog)
-       PHP_DEP_FE(define_syslog_variables,                                                                                     arginfo_define_syslog_variables)
 #endif
 
        /* functions from lcg.c */
index 800a18115ba823547c8e936dbd180b306c354e9d..a715d731127abeecefa6f93d9a0055fcbc801cba 100644 (file)
@@ -202,7 +202,6 @@ typedef struct _php_basic_globals {
        zend_bool mt_rand_is_seeded; /* Whether mt_rand() has been seeded */
     
        /* syslog.c */
-       int syslog_started;
        char *syslog_device;
 
        /* var.c */
index ccd382f9c6360bacacf0917bdbe949167d637179..3134e1c654b9e76cf30a29d61aa74a467ad7f1de 100644 (file)
@@ -35,7 +35,6 @@ PHP_MSHUTDOWN_FUNCTION(syslog);
 PHP_FUNCTION(openlog);
 PHP_FUNCTION(syslog);
 PHP_FUNCTION(closelog);
-PHP_FUNCTION(define_syslog_variables);
 
 #endif
 
index 5f427ef0508ec4fe8523205c8af763efcee7d9d4..9042672ddb76d082213c357d4efaf8c4f42a7fa0 100644 (file)
@@ -36,8 +36,6 @@
 #include "basic_functions.h"
 #include "php_ext_syslog.h"
 
-static void start_syslog(TSRMLS_D);
-
 /* {{{ PHP_MINIT_FUNCTION
  */
 PHP_MINIT_FUNCTION(syslog)
@@ -105,11 +103,6 @@ PHP_MINIT_FUNCTION(syslog)
 
 PHP_RINIT_FUNCTION(syslog)
 {
-       if (INI_INT("define_syslog_variables")) {
-               start_syslog(TSRMLS_C);
-       } else {
-               BG(syslog_started)=0;
-       }
        BG(syslog_device) = NULL;
        return SUCCESS;
 }
@@ -132,87 +125,6 @@ PHP_MSHUTDOWN_FUNCTION(syslog)
        return SUCCESS;
 }
 
-/* {{{ start_syslog
- */
-static void start_syslog(TSRMLS_D)
-{
-       /* error levels */
-       SET_VAR_LONG("LOG_EMERG", LOG_EMERG); /* system unusable */
-       SET_VAR_LONG("LOG_ALERT", LOG_ALERT); /* immediate action required */
-       SET_VAR_LONG("LOG_CRIT", LOG_CRIT); /* critical conditions */
-       SET_VAR_LONG("LOG_ERR", LOG_ERR); 
-       SET_VAR_LONG("LOG_WARNING", LOG_WARNING);
-       SET_VAR_LONG("LOG_NOTICE", LOG_NOTICE);
-       SET_VAR_LONG("LOG_INFO", LOG_INFO);
-       SET_VAR_LONG("LOG_DEBUG", LOG_DEBUG);
-       /* facility: type of program logging the message */
-       SET_VAR_LONG("LOG_KERN", LOG_KERN);
-       SET_VAR_LONG("LOG_USER", LOG_USER); /* generic user level */
-       SET_VAR_LONG("LOG_MAIL", LOG_MAIL); /* log to email */
-       SET_VAR_LONG("LOG_DAEMON", LOG_DAEMON); /* other system daemons */
-       SET_VAR_LONG("LOG_AUTH", LOG_AUTH);
-#ifndef NETWARE
-       SET_VAR_LONG("LOG_SYSLOG", LOG_SYSLOG);
-#endif
-       SET_VAR_LONG("LOG_LPR", LOG_LPR);
-#ifdef LOG_NEWS
-       /* No LOG_NEWS on HP-UX */
-       SET_VAR_LONG("LOG_NEWS", LOG_NEWS); /* usenet new */
-#endif
-#ifdef LOG_UUCP
-       /* No LOG_UUCP on HP-UX */
-       SET_VAR_LONG("LOG_UUCP", LOG_UUCP);
-#endif
-#ifdef LOG_CRON
-       /* apparently some systems don't have this one */
-       SET_VAR_LONG("LOG_CRON", LOG_CRON);
-#endif
-#ifdef LOG_AUTHPRIV
-       /* AIX doesn't have LOG_AUTHPRIV */
-       SET_VAR_LONG("LOG_AUTHPRIV", LOG_AUTHPRIV);
-#endif
-#if !defined(PHP_WIN32) && !defined(NETWARE)
-       SET_VAR_LONG("LOG_LOCAL0", LOG_LOCAL0);
-       SET_VAR_LONG("LOG_LOCAL1", LOG_LOCAL1);
-       SET_VAR_LONG("LOG_LOCAL2", LOG_LOCAL2);
-       SET_VAR_LONG("LOG_LOCAL3", LOG_LOCAL3);
-       SET_VAR_LONG("LOG_LOCAL4", LOG_LOCAL4);
-       SET_VAR_LONG("LOG_LOCAL5", LOG_LOCAL5);
-       SET_VAR_LONG("LOG_LOCAL6", LOG_LOCAL6);
-       SET_VAR_LONG("LOG_LOCAL7", LOG_LOCAL7);
-#endif
-       /* options */
-       SET_VAR_LONG("LOG_PID", LOG_PID);
-       SET_VAR_LONG("LOG_CONS", LOG_CONS);
-       SET_VAR_LONG("LOG_ODELAY", LOG_ODELAY);
-       SET_VAR_LONG("LOG_NDELAY", LOG_NDELAY);
-#ifdef LOG_NOWAIT
-       /* BeOS doesn't have LOG_NOWAIT */
-       SET_VAR_LONG("LOG_NOWAIT", LOG_NOWAIT);
-#endif
-#ifdef LOG_PERROR
-       /* AIX doesn't have LOG_PERROR */
-       SET_VAR_LONG("LOG_PERROR", LOG_PERROR); /*log to stderr*/
-#endif
-
-       BG(syslog_started)=1;
-}
-/* }}} */
-
-/* {{{ proto void define_syslog_variables(void)
-   Initializes all syslog-related variables */
-PHP_FUNCTION(define_syslog_variables)
-{
-       if (zend_parse_parameters_none() == FAILURE) {
-               return;
-       }
-
-       if (!BG(syslog_started)) {
-               start_syslog(TSRMLS_C);
-       }
-}
-/* }}} */
-
 /* {{{ proto bool openlog(string ident, int option, int facility)
    Open connection to system logger */
 /*
diff --git a/ext/standard/tests/misc/syslog_vars_variation1.phpt b/ext/standard/tests/misc/syslog_vars_variation1.phpt
deleted file mode 100644 (file)
index ae53a57..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
---TEST--
-define_syslog_variables() variation 1
---INI--
-define_syslog_variables=On
---FILE--
-<?php
-var_dump(isset($LOG_ERR));
-?>
---EXPECTF--
-Warning: Directive 'define_syslog_variables' is deprecated in PHP 5.3 and greater in Unknown on line 0
-bool(true)
diff --git a/ext/standard/tests/misc/syslog_vars_variation2.phpt b/ext/standard/tests/misc/syslog_vars_variation2.phpt
deleted file mode 100644 (file)
index bdd445b..0000000
+++ /dev/null
@@ -1,52 +0,0 @@
---TEST--
-define_syslog_variables() variation 2
---FILE--
-<?php
-define_syslog_variables();
-
-$standard_types = Array(
-                       'LOG_EMERG', 
-                       'LOG_ALERT', 
-                       'LOG_CRIT', 
-                       'LOG_ERR', 
-                       'LOG_WARNING', 
-                       'LOG_NOTICE', 
-                       'LOG_INFO', 
-                       'LOG_DEBUG', 
-                       'LOG_KERN', 
-                       'LOG_USER', 
-                       'LOG_MAIL', 
-                       'LOG_DAEMON', 
-                       'LOG_AUTH', 
-                       'LOG_LPR', 
-                       'LOG_PID', 
-                       'LOG_CONS', 
-                       'LOG_ODELAY', 
-                       'LOG_NDELAY'
-                       );
-
-foreach($standard_types as $logtype)
-{
-       var_dump(isset(${$logtype}));
-}
-?>
---EXPECTF--
-Deprecated: Function define_syslog_variables() is deprecated in %s on line %d
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
-bool(true)
diff --git a/ext/standard/tests/network/define_syslog_variables_basic-win32.phpt b/ext/standard/tests/network/define_syslog_variables_basic-win32.phpt
deleted file mode 100644 (file)
index 395e3af..0000000
+++ /dev/null
@@ -1,107 +0,0 @@
---TEST--
-Test define_syslog_variables() function : basic functionality
---SKIPIF--
-<?php
-if(substr(PHP_OS, 0, 3) != "WIN")
-  die("skip Only run on Windows");
-?> 
---FILE--
-<?php
-/* Prototype  : void define_syslog_variables(void)
- * Description: Initializes all syslog-related variables 
- * Source code: ext/standard/syslog.c
- * Alias to functions: 
- */
-echo "*** Testing define_syslog_variables() : basic functionality ***\n";
-
-$log_constants = array(
-               LOG_EMERG, 
-               LOG_ALERT, 
-               LOG_CRIT, 
-               LOG_ERR, 
-               LOG_WARNING, 
-               LOG_NOTICE, 
-               LOG_INFO, 
-               LOG_DEBUG,
-               LOG_KERN, 
-               LOG_USER, 
-               LOG_MAIL, 
-               LOG_DAEMON, 
-               LOG_AUTH, 
-               LOG_SYSLOG, 
-               LOG_LPR, 
-               LOG_NEWS, 
-               LOG_UUCP, 
-               LOG_CRON, 
-               LOG_AUTHPRIV,
-               LOG_PID, 
-               LOG_CONS, 
-               LOG_ODELAY, 
-               LOG_NDELAY, 
-               LOG_NOWAIT, 
-               LOG_PERROR,
-);
-
-
-$log_variables = array(
-               "LOG_EMERG", 
-               "LOG_ALERT", 
-               "LOG_CRIT", 
-               "LOG_ERR", 
-               "LOG_WARNING", 
-               "LOG_NOTICE", 
-               "LOG_INFO", 
-               "LOG_DEBUG",
-               "LOG_KERN", 
-               "LOG_USER", 
-               "LOG_MAIL", 
-               "LOG_DAEMON", 
-               "LOG_AUTH", 
-               "LOG_SYSLOG", 
-               "LOG_LPR", 
-               "LOG_NEWS", 
-               "LOG_UUCP", 
-               "LOG_CRON", 
-               "LOG_AUTHPRIV",
-               "LOG_PID", 
-               "LOG_CONS", 
-               "LOG_ODELAY", 
-               "LOG_NDELAY", 
-               "LOG_NOWAIT", 
-               "LOG_PERROR",
-);
-
-error_reporting(E_ALL);
-$failed = false;
-
-// show variables not defined
-foreach($log_variables as $log_var) {
-   if (isset($$log_var)) {
-      $failed = true;
-      echo "FAILED: variable defined\n";
-   }
-} 
-
-var_dump( define_syslog_variables() );
-
-// show variables defined
-for ($t = 0; $t < count($log_variables); $t++) {
-   if (isset($$log_variables[$t]) === false || $$log_variables[$t] != $log_constants[$t]) {
-      $failed = true;
-      echo "FAILED: $log_variables[$t] doesn't contain the correct value\n";
-   }
-}
-
-if ($failed == false) {
-   echo "PASSED\n";
-}
-?>
-===DONE===
---EXPECTF--
-*** Testing define_syslog_variables() : basic functionality ***
-
-Deprecated: Function define_syslog_variables() is deprecated in %s on line %d
-NULL
-PASSED
-===DONE===
diff --git a/ext/standard/tests/network/define_syslog_variables_basic.phpt b/ext/standard/tests/network/define_syslog_variables_basic.phpt
deleted file mode 100644 (file)
index 8ccb16a..0000000
+++ /dev/null
@@ -1,126 +0,0 @@
---TEST--
-Test define_syslog_variables() function : basic functionality 
---SKIPIF--
-<?php
-if(substr(PHP_OS, 0, 3) == "WIN")
-  die("skip don't run on Windows");
-?> 
---FILE--
-<?php
-/* Prototype  : void define_syslog_variables(void)
- * Description: Initializes all syslog-related variables 
- * Source code: ext/standard/syslog.c
- * Alias to functions: 
- */
-echo "*** Testing define_syslog_variables() : basic functionality ***\n";
-
-$log_constants = array(
-               LOG_EMERG, 
-               LOG_ALERT, 
-               LOG_CRIT, 
-               LOG_ERR, 
-               LOG_WARNING, 
-               LOG_NOTICE, 
-               LOG_INFO, 
-               LOG_DEBUG,
-               LOG_KERN, 
-               LOG_USER, 
-               LOG_MAIL, 
-               LOG_DAEMON, 
-               LOG_AUTH, 
-               LOG_SYSLOG, 
-               LOG_LPR, 
-               LOG_NEWS, 
-               LOG_UUCP, 
-               LOG_CRON, 
-               LOG_AUTHPRIV,
-               LOG_PID, 
-               LOG_CONS, 
-               LOG_ODELAY, 
-               LOG_NDELAY, 
-               LOG_NOWAIT, 
-               LOG_PERROR,
-               
-               LOG_LOCAL0, 
-               LOG_LOCAL1, 
-               LOG_LOCAL2, 
-               LOG_LOCAL3, 
-               LOG_LOCAL4, 
-               LOG_LOCAL5, 
-               LOG_LOCAL6, 
-               LOG_LOCAL7              
-
-);
-
-
-$log_variables = array(
-               "LOG_EMERG", 
-               "LOG_ALERT", 
-               "LOG_CRIT", 
-               "LOG_ERR", 
-               "LOG_WARNING", 
-               "LOG_NOTICE", 
-               "LOG_INFO", 
-               "LOG_DEBUG",
-               "LOG_KERN", 
-               "LOG_USER", 
-               "LOG_MAIL", 
-               "LOG_DAEMON", 
-               "LOG_AUTH", 
-               "LOG_SYSLOG", 
-               "LOG_LPR", 
-               "LOG_NEWS", 
-               "LOG_UUCP", 
-               "LOG_CRON", 
-               "LOG_AUTHPRIV",
-               "LOG_PID", 
-               "LOG_CONS", 
-               "LOG_ODELAY", 
-               "LOG_NDELAY", 
-               "LOG_NOWAIT", 
-               "LOG_PERROR",
-               
-               "LOG_LOCAL0", 
-               "LOG_LOCAL1", 
-               "LOG_LOCAL2", 
-               "LOG_LOCAL3", 
-               "LOG_LOCAL4", 
-               "LOG_LOCAL5", 
-               "LOG_LOCAL6", 
-               "LOG_LOCAL7"            
-);
-
-error_reporting(E_ALL);
-$failed = false;
-
-// show variables not defined
-foreach($log_variables as $log_var) {
-   if (isset($$log_var)) {
-      $failed = true;
-      echo "FAILED: variable defined\n";
-   }
-} 
-
-var_dump( define_syslog_variables() );
-
-// show variables now defined
-for ($t = 0; $t < count($log_variables); $t++) {
-   if (isset($$log_variables[$t]) === false || $$log_variables[$t] != $log_constants[$t]) {
-      $failed = true;
-      echo "FAILED: $log_variables[$t] doesn't contain the correct value\n";
-   }
-}
-
-if ($failed == false) {
-   echo "PASSED\n";
-}
-?>
-===DONE===
---EXPECTF--
-*** Testing define_syslog_variables() : basic functionality ***
-
-Deprecated: Function define_syslog_variables() is deprecated in %s on line %d
-NULL
-PASSED
-===DONE===
diff --git a/ext/standard/tests/network/define_syslog_variables_error.phpt b/ext/standard/tests/network/define_syslog_variables_error.phpt
deleted file mode 100644 (file)
index 4348895..0000000
+++ /dev/null
@@ -1,29 +0,0 @@
---TEST--
-Test define_syslog_variables() function : error conditions 
---FILE--
-<?php
-/* Prototype  : void define_syslog_variables(void)
- * Description: Initializes all syslog-related variables 
- * Source code: ext/standard/syslog.c
- * Alias to functions: 
- */
-
-echo "*** Testing define_syslog_variables() : error conditions ***\n";
-
-// One argument
-echo "\n-- Testing define_syslog_variables() function with one argument --\n";
-$extra_arg = 10;
-var_dump( define_syslog_variables($extra_arg) );
-
-?>
-===DONE===
---EXPECTF--
-*** Testing define_syslog_variables() : error conditions ***
-
--- Testing define_syslog_variables() function with one argument --
-
-Deprecated: Function define_syslog_variables() is deprecated in %s on line %d
-
-Warning: define_syslog_variables() expects exactly 0 parameters, 1 given in %s on line %d
-NULL
-===DONE===
diff --git a/ext/standard/tests/network/define_syslog_variables_variation.phpt b/ext/standard/tests/network/define_syslog_variables_variation.phpt
deleted file mode 100644 (file)
index e5842b0..0000000
+++ /dev/null
@@ -1,92 +0,0 @@
---TEST--
-Test define_syslog_variables() function : variation
---FILE--
-<?php
-/* Prototype  : void define_syslog_variables(void)
- * Description: Initializes all syslog-related variables 
- * Source code: ext/standard/syslog.c
- * Alias to functions: 
- */
-define_syslog_variables();
-
-echo "*** Testing define_syslog_variables() : variation ***\n";
-
-$log_constants = array(
-               LOG_EMERG, 
-               LOG_ALERT, 
-               LOG_CRIT, 
-               LOG_ERR, 
-               LOG_WARNING, 
-               LOG_NOTICE, 
-               LOG_INFO, 
-               LOG_DEBUG,
-               LOG_KERN, 
-               LOG_USER, 
-               LOG_MAIL, 
-               LOG_DAEMON, 
-               LOG_AUTH, 
-               LOG_SYSLOG, 
-               LOG_LPR, 
-               LOG_NEWS, 
-               LOG_UUCP, 
-               LOG_CRON, 
-               LOG_AUTHPRIV,
-               LOG_PID, 
-               LOG_CONS, 
-               LOG_ODELAY, 
-               LOG_NDELAY, 
-               LOG_NOWAIT, 
-               LOG_PERROR,
-);
-
-
-$log_variables = array(
-               "LOG_EMERG", 
-               "LOG_ALERT", 
-               "LOG_CRIT", 
-               "LOG_ERR", 
-               "LOG_WARNING", 
-               "LOG_NOTICE", 
-               "LOG_INFO", 
-               "LOG_DEBUG",
-               "LOG_KERN", 
-               "LOG_USER", 
-               "LOG_MAIL", 
-               "LOG_DAEMON", 
-               "LOG_AUTH", 
-               "LOG_SYSLOG", 
-               "LOG_LPR", 
-               "LOG_NEWS", 
-               "LOG_UUCP", 
-               "LOG_CRON", 
-               "LOG_AUTHPRIV",
-               "LOG_PID", 
-               "LOG_CONS", 
-               "LOG_ODELAY", 
-               "LOG_NDELAY", 
-               "LOG_NOWAIT", 
-               "LOG_PERROR",
-);
-
-error_reporting(E_ALL);
-$failed = false;
-
-// show variables defined
-for ($t = 0; $t < count($log_variables); $t++) {
-   if (isset($$log_variables[$t]) === false || $$log_variables[$t] != $log_constants[$t]) {
-      $failed = true;
-      echo "FAILED: $log_variables[$t] doesn't contain the correct value\n";
-   }
-}
-
-if ($failed == false) {
-   echo "PASSED\n";
-}
-?>
-===DONE===
---EXPECTF--
-Deprecated: Function define_syslog_variables() is deprecated in %s on line %d
-*** Testing define_syslog_variables() : variation ***
-PASSED
-===DONE===
diff --git a/ext/standard/tests/network/define_syslog_variables_variation2-win32.phpt b/ext/standard/tests/network/define_syslog_variables_variation2-win32.phpt
deleted file mode 100644 (file)
index a8785fe..0000000
+++ /dev/null
@@ -1,96 +0,0 @@
---TEST--
-Test define_syslog_variables() function : variation
---INI--
-define_syslog_variables = false
---SKIPIF--
-<?php
-if(substr(PHP_OS, 0, 3) != "WIN")
-  die("skip Only run on Windows");
-?> 
---FILE--
-<?php
-/* Prototype  : void define_syslog_variables(void)
- * Description: Initializes all syslog-related variables 
- * Source code: ext/standard/syslog.c
- * Alias to functions: 
- */
-
-echo "*** Testing define_syslog_variables() : variation ***\n";
-
-$log_constants = array(
-               LOG_EMERG, 
-               LOG_ALERT, 
-               LOG_CRIT, 
-               LOG_ERR, 
-               LOG_WARNING, 
-               LOG_NOTICE, 
-               LOG_INFO, 
-               LOG_DEBUG,
-               LOG_KERN, 
-               LOG_USER, 
-               LOG_MAIL, 
-               LOG_DAEMON, 
-               LOG_AUTH, 
-               LOG_SYSLOG, 
-               LOG_LPR, 
-               LOG_NEWS, 
-               LOG_UUCP, 
-               LOG_CRON, 
-               LOG_AUTHPRIV,
-               LOG_PID, 
-               LOG_CONS, 
-               LOG_ODELAY, 
-               LOG_NDELAY, 
-               LOG_NOWAIT, 
-               LOG_PERROR,
-);
-
-
-$log_variables = array(
-               "LOG_EMERG", 
-               "LOG_ALERT", 
-               "LOG_CRIT", 
-               "LOG_ERR", 
-               "LOG_WARNING", 
-               "LOG_NOTICE", 
-               "LOG_INFO", 
-               "LOG_DEBUG",
-               "LOG_KERN", 
-               "LOG_USER", 
-               "LOG_MAIL", 
-               "LOG_DAEMON", 
-               "LOG_AUTH", 
-               "LOG_SYSLOG", 
-               "LOG_LPR", 
-               "LOG_NEWS", 
-               "LOG_UUCP", 
-               "LOG_CRON", 
-               "LOG_AUTHPRIV",
-               "LOG_PID", 
-               "LOG_CONS", 
-               "LOG_ODELAY", 
-               "LOG_NDELAY", 
-               "LOG_NOWAIT", 
-               "LOG_PERROR",
-);
-
-error_reporting(E_ALL);
-$failed = false;
-
-// show variables not defined
-foreach($log_variables as $log_var) {
-   if (isset($$log_var)) {
-      $failed = true;
-      echo "FAILED: variable defined\n";
-   }
-} 
-
-if ($failed == false) {
-   echo "PASSED\n";
-}
-?>
-===DONE===
---EXPECT--
-*** Testing define_syslog_variables() : variation ***
-PASSED
-===DONE===
diff --git a/ext/standard/tests/network/define_syslog_variables_variation2.phpt b/ext/standard/tests/network/define_syslog_variables_variation2.phpt
deleted file mode 100644 (file)
index da68df2..0000000
+++ /dev/null
@@ -1,96 +0,0 @@
---TEST--
-Test define_syslog_variables() function : variation
---SKIPIF--
-<?php
-if(substr(PHP_OS, 0, 3) == "WIN")
-  die("skip don't run on Windows");
-?> 
---INI--
-define_syslog_variables = false
---FILE--
-<?php
-/* Prototype  : void define_syslog_variables(void)
- * Description: Initializes all syslog-related variables 
- * Source code: ext/standard/syslog.c
- * Alias to functions: 
- */
-echo "*** Testing define_syslog_variables() : variation ***\n";
-
-$log_constants = array(
-               LOG_EMERG, 
-               LOG_ALERT, 
-               LOG_CRIT, 
-               LOG_ERR, 
-               LOG_WARNING, 
-               LOG_NOTICE, 
-               LOG_INFO, 
-               LOG_DEBUG,
-               LOG_KERN, 
-               LOG_USER, 
-               LOG_MAIL, 
-               LOG_DAEMON, 
-               LOG_AUTH, 
-               LOG_SYSLOG, 
-               LOG_LPR, 
-               LOG_NEWS, 
-               LOG_UUCP, 
-               LOG_CRON, 
-               LOG_AUTHPRIV,
-               LOG_PID, 
-               LOG_CONS, 
-               LOG_ODELAY, 
-               LOG_NDELAY, 
-               LOG_NOWAIT, 
-               LOG_PERROR,
-);
-
-
-$log_variables = array(
-               "LOG_EMERG", 
-               "LOG_ALERT", 
-               "LOG_CRIT", 
-               "LOG_ERR", 
-               "LOG_WARNING", 
-               "LOG_NOTICE", 
-               "LOG_INFO", 
-               "LOG_DEBUG",
-               "LOG_KERN", 
-               "LOG_USER", 
-               "LOG_MAIL", 
-               "LOG_DAEMON", 
-               "LOG_AUTH", 
-               "LOG_SYSLOG", 
-               "LOG_LPR", 
-               "LOG_NEWS", 
-               "LOG_UUCP", 
-               "LOG_CRON", 
-               "LOG_AUTHPRIV",
-               "LOG_PID", 
-               "LOG_CONS", 
-               "LOG_ODELAY", 
-               "LOG_NDELAY", 
-               "LOG_NOWAIT", 
-               "LOG_PERROR",
-);
-
-error_reporting(E_ALL);
-$failed = false;
-
-// show variables not defined
-foreach($log_variables as $log_var) {
-   if (isset($$log_var)) {
-      $failed = true;
-      echo "FAILED: variable defined\n";
-   }
-} 
-
-if ($failed == false) {
-   echo "PASSED\n";
-}
-?>
-===DONE===
---EXPECT--
-*** Testing define_syslog_variables() : variation ***
-PASSED
-===DONE===
index 79138df20abecebad765365d1f00a38f91acb194..92630c8a8004721ee4d9df32bc6756276610f4c0 100644 (file)
@@ -425,7 +425,6 @@ static PHP_INI_MH(OnChangeMailForceExtra)
 /* {{{ PHP_INI
  */
 PHP_INI_BEGIN()
-       PHP_INI_ENTRY_EX("define_syslog_variables",     "0",                            PHP_INI_ALL,    NULL,                   php_ini_boolean_displayer_cb)
        PHP_INI_ENTRY_EX("highlight.bg",                        HL_BG_COLOR,            PHP_INI_ALL,    NULL,                   php_ini_color_displayer_cb)
        PHP_INI_ENTRY_EX("highlight.comment",           HL_COMMENT_COLOR,       PHP_INI_ALL,    NULL,                   php_ini_color_displayer_cb)
        PHP_INI_ENTRY_EX("highlight.default",           HL_DEFAULT_COLOR,       PHP_INI_ALL,    NULL,                   php_ini_color_displayer_cb)
@@ -2061,29 +2060,50 @@ int php_module_startup(sapi_module_struct *sf, zend_module_entry *additional_mod
        /* Check for deprecated directives */
        /* NOTE: If you add anything here, remember to add it also in Makefile.global! */
        {
-               static const char *directives[] = {
-                       "define_syslog_variables", 
-                       "register_globals", 
-                       "register_long_arrays", 
-                       "safe_mode", 
-                       "magic_quotes_gpc", 
-                       "magic_quotes_runtime", 
-                       "magic_quotes_sybase", 
-                       NULL
+               struct {
+                       const long error_level;
+                       const char *phrase;
+                       const char *directives[7]; /* Remember to change this if the number of directives change */
+               } directives[] = {
+                       {
+                               E_CORE_WARNING, 
+                               "Directive '%s' is deprecated in PHP 5.3 and greater", 
+                               {
+                                       "register_globals", 
+                                       "register_long_arrays", 
+                                       "safe_mode", 
+                                       "magic_quotes_gpc", 
+                                       "magic_quotes_runtime", 
+                                       "magic_quotes_sybase", 
+                                       NULL
+                               }
+                       }, 
+                       {
+                               E_CORE_ERROR, 
+                               "Directive '%s' is no longer available in PHP", 
+                               {
+                                       "define_syslog_variables", 
+                                       "zend.ze1_compatibility_mode", 
+                                       NULL
+                               }
+                       }
                };
-               const char **p = directives;
-               long val;
 
-               while (*p) {
-                       if (cfg_get_long((char*)*p, &val) == SUCCESS && val) {
-                               zend_error(E_WARNING, "Directive '%s' is deprecated in PHP 5.3 and greater", *p);
-                       }
-                       ++p;
-               }
+               unsigned int i;
 
-               /* This is not too nice, but since its the only one theres no need for extra stuff here */
-               if (cfg_get_long("zend.ze1_compatibility_mode", &val) == SUCCESS && val) {
-                       zend_error(E_ERROR, "zend.ze1_compatibility_mode is no longer supported in PHP 5.3 and greater");
+               /* 2 = Count of deprecation structs */
+               for (i = 0; i < 2; i++) {
+                       const char **p = directives[i].directives;
+
+                       while(*p) {
+                               long value;
+
+                               if (cfg_get_long((char*)*p, &value) == SUCCESS && value) {
+                                       zend_error(directives[i].error_level, directives[i].phrase, *p);
+                               }
+
+                               ++p;
+                       }
                }
        }
        
index 123187350d1e4fa4c26b8149f0838576dd60f8f1..d718b2815a4135d6e2b7533812258d210e1814fd 100644 (file)
@@ -1071,13 +1071,6 @@ pdo_mysql.default_socket=
 
 ;phar.cache_list =
 
-[Syslog]
-; Whether or not to define the various syslog variables (e.g. $LOG_PID,
-; $LOG_CRON, etc.).  Turning it off is a good idea performance-wise.  In
-; runtime, you can define these variables by calling define_syslog_variables().
-; http://php.net/define-syslog-variables
-define_syslog_variables  = Off
-
 [mail function]
 ; For Win32 only.
 ; http://php.net/smtp
index 448be26405acd4e338b9a1cfb4c75b08158e77bb..c92690c7fed60c85f9e85d96c344f8973e0f8778 100644 (file)
@@ -1071,13 +1071,6 @@ pdo_mysql.default_socket=
 
 ;phar.cache_list =
 
-[Syslog]
-; Whether or not to define the various syslog variables (e.g. $LOG_PID,
-; $LOG_CRON, etc.).  Turning it off is a good idea performance-wise.  In
-; runtime, you can define these variables by calling define_syslog_variables().
-; http://php.net/define-syslog-variables
-define_syslog_variables  = Off
-
 [mail function]
 ; For Win32 only.
 ; http://php.net/smtp