Issue #15759: "make suspicious", "make linkcheck" and "make doctest" in Doc/

now display special message when and only when there are failures.

diff --git a/Doc/Makefile b/Doc/Makefile
index afdf35f676e07197509c63f91f12bd48c733f401..07bf9b280001df6d4ab3400a4f7bdcfe6a19ac3c 100644 (file)
--- a/Doc/Makefile
+++ b/Doc/Makefile
@@ -86,24 +86,30 @@ changes: build
        @echo "The overview file is in build/changes."
 
 linkcheck: BUILDER = linkcheck
-linkcheck: build
-       @echo "Link check complete; look for any errors in the above output" \
-             "or in build/$(BUILDER)/output.txt"
+linkcheck:
+       @$(MAKE) build BUILDER=$(BUILDER) || { \
+       echo "Link check complete; look for any errors in the above output" \
+            "or in build/$(BUILDER)/output.txt"; \
+       false; }
 
 suspicious: BUILDER = suspicious
-suspicious: build
-       @echo "Suspicious check complete; look for any errors in the above output" \
-             "or in build/$(BUILDER)/suspicious.csv.  If all issues are false" \
-             "positives, append that file to tools/sphinxext/susp-ignored.csv."
+suspicious:
+       @$(MAKE) build BUILDER=$(BUILDER) || { \
+       echo "Suspicious check complete; look for any errors in the above output" \
+            "or in build/$(BUILDER)/suspicious.csv.  If all issues are false" \
+            "positives, append that file to tools/sphinxext/susp-ignored.csv."; \
+       false; }
 
 coverage: BUILDER = coverage
 coverage: build
        @echo "Coverage finished; see c.txt and python.txt in build/coverage"
 
 doctest: BUILDER = doctest
-doctest: build
-       @echo "Testing of doctests in the sources finished, look at the" \
-             "results in build/doctest/output.txt"
+doctest:
+       @$(MAKE) build BUILDER=$(BUILDER) || { \
+       echo "Testing of doctests in the sources finished, look at the" \
+            "results in build/doctest/output.txt"; \
+       false; }
 
 pydoc-topics: BUILDER = pydoc-topics
 pydoc-topics: build

diff --git a/Misc/NEWS b/Misc/NEWS
index 433b273c177f247657218bc37a71d1385d970558..5dfeb829f389cadc3ac7b671803f82a1f2d9b7c3 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -43,6 +43,12 @@ Tests
 - Issue #21976: Fix test_ssl to accept LibreSSL version strings.  Thanks
   to William Orr.
 
+Build
+-----
+
+- Issue #15759: "make suspicious", "make linkcheck" and "make doctest" in Doc/
+  now display special message when and only when there are failures.
+
 
 What's New in Python 2.7.8?
 ===========================