]> granicus.if.org Git - python/commitdiff
Fixed #18150: duplicate test inside TestSingleDispatch
authorŁukasz Langa <lukasz@langa.pl>
Fri, 7 Jun 2013 20:25:27 +0000 (22:25 +0200)
committerŁukasz Langa <lukasz@langa.pl>
Fri, 7 Jun 2013 20:25:27 +0000 (22:25 +0200)
Thanks to Vajrasky Kok for the patch

Lib/test/test_functools.py
Misc/ACKS

index a6b1e03ad7e2cf5e2dc48fa8af27264d616dcff0..49c807d059241a47539e7c3fc3d70c165f9d3bea 100644 (file)
@@ -868,29 +868,24 @@ class TestSingleDispatch(unittest.TestCase):
         @functools.singledispatch
         def g(obj):
             return "base"
-        class C:
+        class A:
             pass
-        class D(C):
+        class C(A):
             pass
-        def g_C(c):
-            return "C"
-        g.register(C, g_C)
-        self.assertEqual(g(C()), "C")
-        self.assertEqual(g(D()), "C")
-
-    def test_classic_classes(self):
-        @functools.singledispatch
-        def g(obj):
-            return "base"
-        class C:
+        class B(A):
             pass
-        class D(C):
+        class D(C, B):
             pass
-        def g_C(c):
-            return "C"
-        g.register(C, g_C)
-        self.assertEqual(g(C()), "C")
-        self.assertEqual(g(D()), "C")
+        def g_A(a):
+            return "A"
+        def g_B(b):
+            return "B"
+        g.register(A, g_A)
+        g.register(B, g_B)
+        self.assertEqual(g(A()), "A")
+        self.assertEqual(g(B()), "B")
+        self.assertEqual(g(C()), "A")
+        self.assertEqual(g(D()), "B")
 
     def test_register_decorator(self):
         @functools.singledispatch
index 3ce5cd2056173d4ec1aa2f4aeed83c7d444ae708..754500d67140ce1c5b6040847703a183ad5945f2 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -666,6 +666,7 @@ Kubilay Kocak
 Greg Kochanski
 Damon Kohler
 Marko Kohtala
+Vajrasky Kok
 Guido Kollerie
 Jacek Konieczny
 Марк Коренберг