]> granicus.if.org Git - python/commitdiff
possible memory leak in error case (closes #24719)
authorBenjamin Peterson <benjamin@python.org>
Sat, 25 Jul 2015 17:20:13 +0000 (10:20 -0700)
committerBenjamin Peterson <benjamin@python.org>
Sat, 25 Jul 2015 17:20:13 +0000 (10:20 -0700)
Patch by Pankaj Sharma.

Modules/cPickle.c

index 10199eb3bdb33554aee3551d9b86c95d5065c073..91f3ee7bd5a0e710522ba9286104c697dc2f8e55 100644 (file)
@@ -2910,7 +2910,7 @@ Pickle_getvalue(Picklerobject *self, PyObject *args)
             if (ik >= lm || ik == 0) {
                 PyErr_SetString(PicklingError,
                                 "Invalid get data");
-                return NULL;
+                goto err;
             }
             have_get[ik] = 1;
             rsize += ik < 256 ? 2 : 5;