while technically uldap_connection_cleanup() does leave an entry in the

connection list, it is fully disconnected before it's put back.  My previous
commentary did more harm then good.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@593283 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/include/util_ldap.h b/include/util_ldap.h
index 5d79387cca493a149e15b58e4807c7ce286ea192..6109e3019620f2d646129fa1fffd42423a22135e 100644 (file)
--- a/include/util_ldap.h
+++ b/include/util_ldap.h
@@ -190,7 +190,7 @@ APR_DECLARE_OPTIONAL_FN(apr_status_t,uldap_connection_unbind,(void *param));
  * Cleanup a connection to an LDAP server
  * @param ldc A structure containing the expanded details of the server
  *            that was connected.
- * @tip The connection is unlocked and returned to the list of free connections
+ * @tip This functions unbinds and closes the connection to the LDAP server
  * @fn apr_status_t util_ldap_connection_cleanup(util_ldap_connection_t *ldc)
  */
 APR_DECLARE_OPTIONAL_FN(apr_status_t,uldap_connection_cleanup,(void *param));

diff --git a/modules/ldap/util_ldap.c b/modules/ldap/util_ldap.c
index 280abadf3fd83de0ad11ecc53153852807b6090e..cacf91c4d06d7121ebc80268c8fd3a82cc008f06 100644 (file)
--- a/modules/ldap/util_ldap.c
+++ b/modules/ldap/util_ldap.c
@@ -171,8 +171,7 @@ static apr_status_t uldap_connection_unbind(void *param)
 
 
 /*
- * Clean up an LDAP connection by unbinding and unlocking the connection,
- * causing it to be returned to the list of free connections
+ * Clean up an LDAP connection by unbinding and unlocking the connection.
  */
 static apr_status_t uldap_connection_cleanup(void *param)
 {