MFB: Fixed bug #44836 (putenv() crashes, avoid direct reference of environ

in POSIX systems).

diff --git a/ext/standard/basic_functions.c b/ext/standard/basic_functions.c
index 358e8e821e44f34220a9e63ac97a81cf51a199ad..7b29618b27f3604d79e9144b5f1db1aca12174ce 100644 (file)
--- a/ext/standard/basic_functions.c
+++ b/ext/standard/basic_functions.c
@@ -3822,9 +3822,7 @@ static void php_putenv_destructor(putenv_entry *pe) /* {{{ */
                SetEnvironmentVariable(pe->key, "bugbug");
 #endif
                putenv(pe->previous_value);
-# if defined(PHP_WIN32)
                efree(pe->previous_value);
-# endif
        } else {
 # if HAVE_UNSETENV
                unsetenv(pe->key);
@@ -4388,12 +4386,8 @@ PHP_FUNCTION(putenv)
                pe.previous_value = NULL;
                for (env = environ; env != NULL && *env != NULL; env++) {
                        if (!strncmp(*env, pe.key, pe.key_len) && (*env)[pe.key_len] == '=') {  /* found it */
-#if defined(PHP_WIN32)
-                               /* must copy previous value because MSVCRT's putenv can free the string without notice */
+                               /* must copy previous value because putenv can free the string without notice */
                                pe.previous_value = estrdup(*env);
-#else
-                               pe.previous_value = *env;
-#endif
                                break;
                        }
                }