Check that AsyncRequestWorkerFactor is not negative

PR :54254
Submitted by: Jackie Zhang <jackie qq zhang gmail com>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1425777 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index d53402ace1b8f6c489d28b2f3fa9598b3e4cc333..27d061975af867a55b295cabfe6007041567c6b0 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,9 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.5.0
 
+  *) mpm_event: Check that AsyncRequestWorkerFactor is not negative. PR 54254.
+     [Jackie Zhang <jackie qq zhang gmail com>]
+
   *) httxt2dbm: Correct length computation for the 'value' stored in the DBM file
      PR 47650 [jon buckybox com]
 

diff --git a/server/mpm/event/event.c b/server/mpm/event/event.c
index 9c18af354cd4f7e85407de663df5fdb352778d78..23d3c0e0105d2c2e9b2f20ab55af6ec409ea5df7 100644 (file)
--- a/server/mpm/event/event.c
+++ b/server/mpm/event/event.c
@@ -3338,6 +3338,9 @@ static const char *set_worker_factor(cmd_parms * cmd, void *dummy,
     if (*endptr)
         return "error parsing value";
 
+    if (val <= 0)
+        return "AsyncRequestWorkerFactor argument must be a positive number";
+
     worker_factor = val * WORKER_FACTOR_SCALE;
     if (worker_factor == 0)
         worker_factor = 1;