]> granicus.if.org Git - clang/commitdiff
Remove a pointless assertion.
authorNico Weber <nicolasweber@gmx.de>
Fri, 15 Mar 2013 15:02:37 +0000 (15:02 +0000)
committerNico Weber <nicolasweber@gmx.de>
Fri, 15 Mar 2013 15:02:37 +0000 (15:02 +0000)
FindNodeOrInsertPos() is called 10 lines earlier already, and the function
early-returns there if the result is != 0. InsertPos isn't recomputed after
that check, so this assert is always trivially true. (And it has nothing to
do with if T is canonical or not.)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@177158 91177308-0d34-0410-b5e6-96231b3b80d8

lib/AST/ASTContext.cpp

index b55a926e32afad2d7de015d45ec88750ed07c8c6..6840726b70a7a51d19d011fa724ec34402053b8a 100644 (file)
@@ -2026,13 +2026,9 @@ QualType ASTContext::getPointerType(QualType T) const {
   // If the pointee type isn't canonical, this won't be a canonical type either,
   // so fill in the canonical type field.
   QualType Canonical;
-  if (!T.isCanonical()) {
+  if (!T.isCanonical())
     Canonical = getPointerType(getCanonicalType(T));
 
-    // Get the new insert position for the node we care about.
-    PointerType *NewIP = PointerTypes.FindNodeOrInsertPos(ID, InsertPos);
-    assert(NewIP == 0 && "Shouldn't be in the map!"); (void)NewIP;
-  }
   PointerType *New = new (*this, TypeAlignment) PointerType(T, Canonical);
   Types.push_back(New);
   PointerTypes.InsertNode(New, InsertPos);