patch 8.2.0718: gcc warning for returning pointer to local variable

Problem:    Gcc warning for returning pointer to local variable. (John
            Marriott)
Solution:   Return another pointer.

diff --git a/src/evalvars.c b/src/evalvars.c
index 08b2990bcc7077f69a7298525a2988262eb4a5a6..0935bb3ebc7d09e031bd135704b785d4d7ff988c 100644 (file)
--- a/src/evalvars.c
+++ b/src/evalvars.c
@@ -2510,6 +2510,7 @@ lookup_scriptvar(char_u *name, size_t len, cctx_T *dummy UNUSED)
        return NULL;
     if (len < sizeof(buffer) - 1)
     {
+       // avoid an alloc/free for short names
        vim_strncpy(buffer, name, len);
        p = buffer;
     }
@@ -2529,7 +2530,8 @@ lookup_scriptvar(char_u *name, size_t len, cctx_T *dummy UNUSED)
 
     if (p != buffer)
        vim_free(p);
-    return res;
+    // Don't return "buffer", gcc complains.
+    return res == NULL ? NULL : IObuff;
 }
 
 /*

diff --git a/src/version.c b/src/version.c
index ba81d6809277a749e0c46d37766264b06fa45287..5c54b428e54f4e6b2dbf5efd71047b12e3212567 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -746,6 +746,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    718,
 /**/
     717,
 /**/