]> granicus.if.org Git - libvpx/commitdiff
Fix bug in setting sf->use_square_partition_only.
authorpaulwilkins <paulwilkins@google.com>
Thu, 16 Jul 2015 15:20:39 +0000 (16:20 +0100)
committerpaulwilkins <paulwilkins@google.com>
Thu, 16 Jul 2015 15:20:39 +0000 (16:20 +0100)
Fix bug in setting this flag for animated content.
The bug did cause quality to increase because far
more frames are not boosted than boosted.

However, the speed trade off to gain is a lot less
favorable and the behavior was not as intended.

Change-Id: I89fb70419c88b26f40b3534de0481730a1b3fcfa

vp9/encoder/vp9_speed_features.c

index e544f9bb4b2f5781a31f5a5122cba19702f3631e..bf06fd0ea8d89c17c1aa78bb1bfc45c1de4b5c96 100644 (file)
@@ -118,10 +118,11 @@ static void set_good_speed_feature(VP9_COMP *cpi, VP9_COMMON *cm,
   if (speed >= 1) {
     if ((cpi->twopass.fr_content_type == FC_GRAPHICS_ANIMATION) ||
         vp9_internal_image_edge(cpi)) {
-      sf->use_square_partition_only = frame_is_boosted(cpi);
+      sf->use_square_partition_only = !frame_is_boosted(cpi);
     } else {
       sf->use_square_partition_only = !frame_is_intra_only(cm);
     }
+
     sf->less_rectangular_check  = 1;
 
     sf->use_rd_breakout = 1;