]> granicus.if.org Git - php/commitdiff
Fix bug #73144 and bug #73341 - remove extra dtor
authorStanislav Malyshev <stas@php.net>
Mon, 24 Oct 2016 04:56:35 +0000 (21:56 -0700)
committerAnatol Belski <ab@php.net>
Tue, 1 Nov 2016 12:01:58 +0000 (13:01 +0100)
(cherry picked from commit f74d7d92c8bc1edc2505e0b58546217e9e1ecb40)

Conflicts:
ext/spl/spl_array.c

Merged the test only, in 7.0 tree the removed dtor call is already
not present.

ext/standard/tests/serialize/bug73341.phpt [new file with mode: 0644]

diff --git a/ext/standard/tests/serialize/bug73341.phpt b/ext/standard/tests/serialize/bug73341.phpt
new file mode 100644 (file)
index 0000000..5542321
--- /dev/null
@@ -0,0 +1,24 @@
+--TEST--
+Bug #73144 (Use-afte-free in ArrayObject Deserialization)
+--FILE--
+<?php
+try {
+$token = 'a:2:{i:0;O:1:"0":2:0s:1:"0";i:0;s:1:"0";a:1:{i:0;C:11:"ArrayObject":7:0x:i:0;r0';
+$obj = unserialize($token);
+} catch(Exception $e) {
+       echo $e->getMessage()."\n";
+}
+
+try {
+$inner = 'x:i:1;O:8:"stdClass":1:{};m:a:0:{}';
+$exploit = 'C:11:"ArrayObject":'.strlen($inner).':{'.$inner.'}';
+unserialize($exploit);
+} catch(Exception $e) {
+       echo $e->getMessage()."\n";
+}
+?>
+--EXPECTF--
+Error at offset 6 of 7 bytes
+
+Notice: ArrayObject::unserialize(): Unexpected end of serialized data in %sbug73341.php on line %d
+Error at offset 24 of 34 bytes
\ No newline at end of file