?Why did my tests not notice this before?

Slots inheritance is very different from OO inheritance.
This code lead to infinite recursion on classes derived from StructType.

diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
index a9eb032b0106b2656823d85189950bf0213baca9..9d7290f8e3774ad999b1d11a98b89c0978017030 100644 (file)
--- a/Modules/_ctypes/_ctypes.c
+++ b/Modules/_ctypes/_ctypes.c
@@ -410,7 +410,7 @@ static int
 StructType_setattro(PyObject *self, PyObject *key, PyObject *value)
 {
        /* XXX Should we disallow deleting _fields_? */
-       if (-1 == Py_TYPE(self)->tp_base->tp_setattro(self, key, value))
+       if (-1 == PyType_Type.tp_setattro(self, key, value))
                return -1;
        
        if (value && PyString_Check(key) &&