- Implemented FR #55166 (Added process.max to control the number of process FPM can...

diff --git a/NEWS b/NEWS
index 708f5cff30cd0d1dd3c047cfdaf64b22eaeb85dc..8455e4e4a6d01bef0358eeb3052307b75c66b08c 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -1,6 +1,9 @@
 PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? 2011, PHP 5.4.0 Alpha 3
+- Improved PHP-FPM SAPI:
+  . Added process.max to control the number of process FPM can fork. FR #55166.
+    (fat)
 
 14 Jul 2011, PHP 5.4.0 Alpha 2
 - General improvements:

diff --git a/sapi/fpm/fpm/fpm.h b/sapi/fpm/fpm/fpm.h
index 3c6f798fba6ff127f2b1b918c3d5a10b9c4b8e79..bfe2be8d1e6e21781a3b859a7b298bef364b7c9f 100644 (file)
--- a/sapi/fpm/fpm/fpm.h
+++ b/sapi/fpm/fpm/fpm.h
@@ -24,6 +24,7 @@ struct fpm_globals_s {
        int max_requests; /* for this child */
        int is_child;
        int test_successful;
+       int process_max; /* global */
 };
 
 extern struct fpm_globals_s fpm_globals;

diff --git a/sapi/fpm/fpm/fpm_children.c b/sapi/fpm/fpm/fpm_children.c
index 65f56e7269b156a5b8bd6b60b5783e08363c73e7..fbe9d980d85bdb377203bdfb87aee3e03e6087ea 100644 (file)
--- a/sapi/fpm/fpm/fpm_children.c
+++ b/sapi/fpm/fpm/fpm_children.c
@@ -363,6 +363,7 @@ int fpm_children_make(struct fpm_worker_pool_s *wp, int in_event_loop, int nb_to
        pid_t pid;
        struct fpm_child_s *child;
        int max;
+       static int warned = 0;
 
        if (wp->config->pm == PM_STYLE_DYNAMIC) {
                if (!in_event_loop) { /* starting */
@@ -374,7 +375,9 @@ int fpm_children_make(struct fpm_worker_pool_s *wp, int in_event_loop, int nb_to
                max = wp->config->pm_max_children;
        }
 
-       while (fpm_pctl_can_spawn_children() && wp->running_children < max) {
+       while (fpm_pctl_can_spawn_children() && wp->running_children < max && fpm_globals.running_children < fpm_global_config.process_max) {
+
+               warned = 0;
                child = fpm_resources_prepare(wp);
 
                if (!child) {
@@ -407,6 +410,11 @@ int fpm_children_make(struct fpm_worker_pool_s *wp, int in_event_loop, int nb_to
 
        }
 
+       if (!warned && fpm_globals.running_children >= fpm_global_config.process_max) {
+               warned = 1;
+               zlog(ZLOG_WARNING, "The maximum number of processes has been reached. Please review your configuration and consider raising 'process.max'");
+       }
+
        return 1; /* we are done */
 }
 /* }}} */

diff --git a/sapi/fpm/fpm/fpm_conf.c b/sapi/fpm/fpm/fpm_conf.c
index 2f28fb946566f1868b304a34439470394afad366..755346fa6faec13fcea1253781694c08860c5d0c 100644 (file)
--- a/sapi/fpm/fpm/fpm_conf.c
+++ b/sapi/fpm/fpm/fpm_conf.c
@@ -66,8 +66,9 @@ static char *fpm_conf_set_syslog_facility(zval *value, void **config, intptr_t o
 struct fpm_global_config_s fpm_global_config = {
        .daemonize = 1,
 #ifdef HAVE_SYSLOG_H
-       .syslog_facility = -1
+       .syslog_facility = -1,
 #endif
+       .process_max = 0,
 };
 static struct fpm_worker_pool_s *current_wp = NULL;
 static int ini_recursion = 0;
@@ -79,6 +80,7 @@ static struct ini_value_parser_s ini_fpm_global_options[] = {
        { "emergency_restart_threshold", &fpm_conf_set_integer,         GO(emergency_restart_threshold) },
        { "emergency_restart_interval",  &fpm_conf_set_time,            GO(emergency_restart_interval) },
        { "process_control_timeout",     &fpm_conf_set_time,            GO(process_control_timeout) },
+       { "process.max",                 &fpm_conf_set_integer,         GO(process_max) },
        { "daemonize",                   &fpm_conf_set_boolean,         GO(daemonize) },
        { "pid",                         &fpm_conf_set_string,          GO(pid_file) },
        { "error_log",                   &fpm_conf_set_string,          GO(error_log) },
@@ -1014,6 +1016,12 @@ static int fpm_conf_post_process(TSRMLS_D) /* {{{ */
 
        fpm_globals.log_level = fpm_global_config.log_level;
 
+       if (fpm_global_config.process_max < 0) {
+               zlog(ZLOG_ERROR, "process_max can't be negative");
+               return -1;
+       }
+       fpm_globals.process_max = fpm_global_config.process_max;
+
        if (!fpm_global_config.error_log) {
                fpm_global_config.error_log = strdup("log/php-fpm.log");
        }
@@ -1394,6 +1402,7 @@ static void fpm_conf_dump() /* {{{ */
        zlog(ZLOG_NOTICE, "\tsyslog.facility = %d",             fpm_global_config.syslog_facility); /* FIXME: convert to string */
 #endif
        zlog(ZLOG_NOTICE, "\tprocess_control_timeout = %ds",    fpm_global_config.process_control_timeout);
+       zlog(ZLOG_NOTICE, "\tprocess.max = %d",                 fpm_global_config.process_max);
        zlog(ZLOG_NOTICE, "\temergency_restart_interval = %ds", fpm_global_config.emergency_restart_interval);
        zlog(ZLOG_NOTICE, "\temergency_restart_threshold = %d", fpm_global_config.emergency_restart_threshold);
        zlog(ZLOG_NOTICE, "\trlimit_files = %d",                fpm_global_config.rlimit_files);

diff --git a/sapi/fpm/fpm/fpm_conf.h b/sapi/fpm/fpm/fpm_conf.h
index d19c2b61f5dca6d4fcc3eefc5330077fea2866d5..11c688ae7b4dbdc22472f0bcab06f06e1c655b98 100644 (file)
--- a/sapi/fpm/fpm/fpm_conf.h
+++ b/sapi/fpm/fpm/fpm_conf.h
@@ -32,6 +32,7 @@ struct fpm_global_config_s {
 #endif
        int rlimit_files;
        int rlimit_core;
+       int process_max;
 };
 
 extern struct fpm_global_config_s fpm_global_config;

diff --git a/sapi/fpm/php-fpm.conf.in b/sapi/fpm/php-fpm.conf.in
index 8c9d4bb406635e9bd6b032bb987989612e6ff899..76a1c36368b9a808e7e0efaa4b5e24a52ed23463 100644 (file)
--- a/sapi/fpm/php-fpm.conf.in
+++ b/sapi/fpm/php-fpm.conf.in
@@ -69,6 +69,13 @@
 ; Default Value: 0
 ;process_control_timeout = 0
 
+; The maximum number of processes FPM will fork. This has been design to control
+; the global number of processes when using dynamic PM within a lot of pools.
+; Use it with caution.
+; Note: A value of 0 indicates no limit
+; Default Value: 0
+; process.max = 128
+
 ; Send FPM to background. Set to 'no' to keep FPM in foreground for debugging.
 ; Default Value: yes
 ;daemonize = yes