]> granicus.if.org Git - python/commitdiff
Merged revisions 83135 via svnmerge from
authorRonald Oussoren <ronaldoussoren@mac.com>
Sat, 24 Jul 2010 14:23:23 +0000 (14:23 +0000)
committerRonald Oussoren <ronaldoussoren@mac.com>
Sat, 24 Jul 2010 14:23:23 +0000 (14:23 +0000)
svn+ssh://pythondev@svn.python.org/python/branches/release27-maint

................
  r83135 | ronald.oussoren | 2010-07-24 15:21:29 +0100 (Sat, 24 Jul 2010) | 12 lines

  Merged revisions 83133 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/branches/py3k

  ........
    r83133 | ronald.oussoren | 2010-07-24 15:15:19 +0100 (Sat, 24 Jul 2010) | 5 lines

    Fix for issue 9367: the test code for os.getgroups
    assumes that the result of getgroups and the output
    of the id(1) command return groups in the same
    order.  That assumption is both fragile and false.
  ........
................

Lib/test/test_posix.py

index 4416f68a451b7302134f3d694976174dc9aebc0e..4c0d53ac05a8c3851dd0b4c46bebfe4809c15a70 100644 (file)
@@ -314,7 +314,11 @@ class PosixTester(unittest.TestCase):
         if not groups:
             raise unittest.SkipTest("need working 'id -G'")
 
-        self.assertEqual([int(x) for x in groups.split()], posix.getgroups())
+        # The order of groups isn't important, hence the calls
+        # to sorted.
+        self.assertEqual(
+                list(sorted([int(x) for x in groups.split()])),
+                list(sorted(posix.getgroups())))
 
 class PosixGroupsTester(unittest.TestCase):
     if posix.getuid() == 0 and hasattr(posix, 'getgroups') and sys.platform != 'darwin':