]> granicus.if.org Git - python/commitdiff
Remove the obsolete MAXFD constant and Popen._close_fds() method.
authorGregory P. Smith <greg@krypto.org>
Sun, 1 Jun 2014 07:33:35 +0000 (00:33 -0700)
committerGregory P. Smith <greg@krypto.org>
Sun, 1 Jun 2014 07:33:35 +0000 (00:33 -0700)
They should have been removed years ago when removing the old pure
Python implementation from the file.

Lib/subprocess.py

index daa3e25c0e4d5b00a6c93db22e1c2cf3e8035d1f..49aa6ab983679c6e2b37344a7c9c4e360c88f845 100644 (file)
@@ -469,10 +469,6 @@ if mswindows:
         __del__ = Close
         __str__ = __repr__
 
-try:
-    MAXFD = os.sysconf("SC_OPEN_MAX")
-except:
-    MAXFD = 256
 
 # This lists holds Popen instances for which the underlying process had not
 # exited at the time its __del__ method got called: those processes are wait()ed
@@ -1335,16 +1331,6 @@ class Popen(object):
                     errread, errwrite)
 
 
-        def _close_fds(self, fds_to_keep):
-            start_fd = 3
-            for fd in sorted(fds_to_keep):
-                if fd >= start_fd:
-                    os.closerange(start_fd, fd)
-                    start_fd = fd + 1
-            if start_fd <= MAXFD:
-                os.closerange(start_fd, MAXFD)
-
-
         def _execute_child(self, args, executable, preexec_fn, close_fds,
                            pass_fds, cwd, env,
                            startupinfo, creationflags, shell,