sadc: Fix use of uninitialized variable

Coverity CID#267242.

Signed-off-by: Sebastien GODARD <sysstat@users.noreply.github.com>

diff --git a/sa_wrap.c b/sa_wrap.c
index f46b3a6e482601c3478afaa1e646e03bb95a4182..c8cdc74ee21004d605fc57bdf2ca865f654c161c 100644 (file)
--- a/sa_wrap.c
+++ b/sa_wrap.c
@@ -1071,7 +1071,7 @@ __read_funct_t wrap_read_fchost(struct activity *a)
  *
  * RETURNS:
  * Number of CPU for which statistics have to be be read.
- * 1 means CPU "all", 2 means CPU 0, 3 means CPU 1, etc.
+ * 1 means CPU "all", 2 means CPU "all" and CPU 0, etc.
  * Or -1 if the buffer was too small and needs to be reallocated.
  ***************************************************************************
  */
@@ -1079,7 +1079,7 @@ int get_online_cpu_list(unsigned char online_cpu_bitmap[], int bitmap_size)
 {
        FILE *fp;
        char line[8192];
-       int proc_nr;
+       int proc_nr = -2;
 
        if ((fp = fopen(STAT, "r")) == NULL)
                return 0;
@@ -1091,13 +1091,13 @@ int get_online_cpu_list(unsigned char online_cpu_bitmap[], int bitmap_size)
 
                if (!strncmp(line, "cpu", 3)) {
                        sscanf(line + 3, "%d", &proc_nr);
-               }
 
-               if (proc_nr + 1 > bitmap_size) {
-                       fclose(fp);
-                       return -1;
+                       if (proc_nr + 1 > bitmap_size) {
+                               fclose(fp);
+                               return -1;
+                       }
+                       online_cpu_bitmap[proc_nr >> 3] |= 1 << (proc_nr & 0x07);
                }
-               online_cpu_bitmap[proc_nr >> 3] |= 1 << (proc_nr & 0x07);
        }
 
        fclose(fp);