php_stream_truncate_set_size() is a noop with temp streams.

so, we're going to use a brand new tempfile for truncation.

ALL TESTS PASS NOW (finally)

diff --git a/ext/phar/phar.c b/ext/phar/phar.c
index e4361854107b91d0380131f91dd3946974086918..22a523b68b47f3234476c3118f7205709f777093 100644 (file)
--- a/ext/phar/phar.c
+++ b/ext/phar/phar.c
@@ -293,9 +293,9 @@ static int phar_get_entry_data(phar_entry_data **ret, char *fname, int fname_len
                        (*ret)->internal_file = entry;
                        if (entry->fp) {
                                /* make a copy */
-                               (*ret)->fp = entry->fp;
                                if (for_trunc) {
-                                       php_stream_truncate_set_size(entry->fp, 0);
+                                       php_stream_close(entry->fp);
+                                       entry->fp = php_stream_fopen_tmpfile();
                                        entry->is_modified = 1;
                                        phar->is_modified = 1;
                                        /* reset file size */
@@ -305,6 +305,7 @@ static int phar_get_entry_data(phar_entry_data **ret, char *fname, int fname_len
                                } else if (for_append) {
                                        php_stream_seek(entry->fp, 0, SEEK_END);
                                }
+                               (*ret)->fp = entry->fp;
                        } else {
                                (*ret)->fp = 0;
                                if (for_write) {