]> granicus.if.org Git - sudo/commitdiff
Check return value of restore_perms() in vlog_warning().
authorTodd C. Miller <Todd.Miller@courtesan.com>
Fri, 6 May 2016 15:26:45 +0000 (09:26 -0600)
committerTodd C. Miller <Todd.Miller@courtesan.com>
Fri, 6 May 2016 15:26:45 +0000 (09:26 -0600)
Coverity CID 104079.

plugins/sudoers/logging.c

index fd9e7b12d6fae624a3bfe088027da22206a3b519..ca82e49b344707abb4e17b44adce1e91596dfa24 100644 (file)
@@ -477,8 +477,10 @@ vlog_warning(int flags, const char *fmt, va_list ap)
            rval = false;
     }
 
-    if (uid_changed)
-       restore_perms();
+    if (uid_changed) {
+       if (!restore_perms())
+           rval = false;
+    }
 
     free(logline);