]> granicus.if.org Git - php/commitdiff
Fixed safe resource close.
authorDmitry Stogov <dmitry@zend.com>
Tue, 13 May 2014 08:47:34 +0000 (12:47 +0400)
committerDmitry Stogov <dmitry@zend.com>
Tue, 13 May 2014 08:47:34 +0000 (12:47 +0400)
It must not de deleted (just closed), because it still may be referenced from zval(s).
This fixes few ext/ftp test memory failures detected with valgrind.

ext/ftp/php_ftp.c

index 2badf294ea61bbf3f681e84289d205e80df4b3b4..46e336deb0f0145514067248ac1f8ab38620c8b8 100644 (file)
@@ -1360,7 +1360,7 @@ PHP_FUNCTION(ftp_close)
 
        ftp_quit(ftp);
 
-       RETURN_BOOL(zend_list_delete(Z_RES_P(z_ftp)) == SUCCESS);
+       RETURN_BOOL(zend_list_close(Z_RES_P(z_ftp)) == SUCCESS);
 }
 /* }}} */