rec: prefer references for function parameters

diff --git a/pdns/dnssecinfra.cc b/pdns/dnssecinfra.cc
index 5f662d18864971b39be683ad0c4a6e5252ab2271..7525eed6419f713c7738383a58c860d84d030c40 100644 (file)
--- a/pdns/dnssecinfra.cc
+++ b/pdns/dnssecinfra.cc
@@ -460,7 +460,7 @@ DSRecordContent makeDSFromDNSKey(const DNSName& qname, const DNSKEYRecordContent
 }
 
 
-static DNSKEYRecordContent makeDNSKEYFromDNSCryptoKeyEngine(const std::shared_ptr<DNSCryptoKeyEngine> pk, uint8_t algorithm, uint16_t flags)
+static DNSKEYRecordContent makeDNSKEYFromDNSCryptoKeyEngine(const std::shared_ptr<DNSCryptoKeyEngine>& pk, uint8_t algorithm, uint16_t flags)
 {
   DNSKEYRecordContent drc;
 

diff --git a/pdns/filterpo.cc b/pdns/filterpo.cc
index c73b202e6b07745e6c04c8701e0f0652ba91d28d..90179584ae6a9253b7825ebf2b2fef9702bd102d 100644 (file)
--- a/pdns/filterpo.cc
+++ b/pdns/filterpo.cc
@@ -231,31 +231,31 @@ void DNSFilterEngine::Zone::addNSIPTrigger(const Netmask& nm, Policy pol)
   d_propolNSAddr.insert(nm).second = pol;
 }
 
-bool DNSFilterEngine::Zone::rmClientTrigger(const Netmask& nm, Policy pol)
+bool DNSFilterEngine::Zone::rmClientTrigger(const Netmask& nm, Policy& pol)
 {
   d_qpolAddr.erase(nm);
   return true;
 }
 
-bool DNSFilterEngine::Zone::rmResponseTrigger(const Netmask& nm, Policy pol)
+bool DNSFilterEngine::Zone::rmResponseTrigger(const Netmask& nm, Policy& pol)
 {
   d_postpolAddr.erase(nm);
   return true;
 }
 
-bool DNSFilterEngine::Zone::rmQNameTrigger(const DNSName& n, Policy pol)
+bool DNSFilterEngine::Zone::rmQNameTrigger(const DNSName& n, Policy& pol)
 {
   d_qpolName.erase(n); // XXX verify we had identical policy?
   return true;
 }
 
-bool DNSFilterEngine::Zone::rmNSTrigger(const DNSName& n, Policy pol)
+bool DNSFilterEngine::Zone::rmNSTrigger(const DNSName& n, Policy& pol)
 {
   d_propolName.erase(n); // XXX verify policy matched? =pol;
   return true;
 }
 
-bool DNSFilterEngine::Zone::rmNSIPTrigger(const Netmask& nm, Policy pol)
+bool DNSFilterEngine::Zone::rmNSIPTrigger(const Netmask& nm, Policy& pol)
 {
   d_propolNSAddr.erase(nm);
   return true;

diff --git a/pdns/filterpo.hh b/pdns/filterpo.hh
index ba43829b49aa1bb1d9e545dbdf828d48942d6a1a..f07d37102ea9f14a33071aee7401ebe846af9a71 100644 (file)
--- a/pdns/filterpo.hh
+++ b/pdns/filterpo.hh
@@ -147,11 +147,11 @@ public:
     void addNSIPTrigger(const Netmask& nm, Policy pol);
     void addResponseTrigger(const Netmask& nm, Policy pol);
 
-    bool rmClientTrigger(const Netmask& nm, Policy pol);
-    bool rmQNameTrigger(const DNSName& nm, Policy pol);
-    bool rmNSTrigger(const DNSName& dn, Policy pol);
-    bool rmNSIPTrigger(const Netmask& nm, Policy pol);
-    bool rmResponseTrigger(const Netmask& nm, Policy pol);
+    bool rmClientTrigger(const Netmask& nm, Policy& pol);
+    bool rmQNameTrigger(const DNSName& nm, Policy& pol);
+    bool rmNSTrigger(const DNSName& dn, Policy& pol);
+    bool rmNSIPTrigger(const Netmask& nm, Policy& pol);
+    bool rmResponseTrigger(const Netmask& nm, Policy& pol);
 
     bool findQNamePolicy(const DNSName& qname, DNSFilterEngine::Policy& pol) const;
     bool findNSPolicy(const DNSName& qname, DNSFilterEngine::Policy& pol) const;

diff --git a/pdns/ixfr.cc b/pdns/ixfr.cc
index 56a69c1df5fae23e89803c84cfb9d2ec152bb8c1..c6b2137532c625f273add805ca43a9658f9ae63e 100644 (file)
--- a/pdns/ixfr.cc
+++ b/pdns/ixfr.cc
@@ -27,7 +27,7 @@
 #include "tsigverifier.hh"
 
 vector<pair<vector<DNSRecord>, vector<DNSRecord> > > processIXFRRecords(const ComboAddress& master, const DNSName& zone,
-                                                                        const vector<DNSRecord>& records, const std::shared_ptr<SOARecordContent> masterSOA)
+                                                                        const vector<DNSRecord>& records, const std::shared_ptr<SOARecordContent>& masterSOA)
 {
   vector<pair<vector<DNSRecord>, vector<DNSRecord> > >  ret;
 

diff --git a/pdns/ixfr.hh b/pdns/ixfr.hh
index 970222f7e50b3681b9ee4ada30dbc24ae8485b78..1d9606a1e92a515b35ef8177db0fadeaa3a0c23b 100644 (file)
--- a/pdns/ixfr.hh
+++ b/pdns/ixfr.hh
@@ -29,4 +29,4 @@ vector<pair<vector<DNSRecord>, vector<DNSRecord> > >   getIXFRDeltas(const Combo
                                                                      const ComboAddress* laddr=0, size_t maxReceivedBytes=0);
 
 vector<pair<vector<DNSRecord>, vector<DNSRecord> > > processIXFRRecords(const ComboAddress& master, const DNSName& zone,
-                                                                        const vector<DNSRecord>& records, const std::shared_ptr<SOARecordContent> masterSOA);
+                                                                        const vector<DNSRecord>& records, const std::shared_ptr<SOARecordContent>& masterSOA);

diff --git a/pdns/sortlist.hh b/pdns/sortlist.hh
index 188728b3b417934a9f254824c6278f722f0be419..cd043295acd4c1e42cfc8522cc22846820eb3fd4 100644 (file)
--- a/pdns/sortlist.hh
+++ b/pdns/sortlist.hh
@@ -31,7 +31,7 @@ struct SortListOrder
 
 struct SortListOrderCmp
 {
-  SortListOrderCmp(SortListOrder slo) : d_slo(slo) {}
+  SortListOrderCmp(const SortListOrder& slo) : d_slo(slo) {}
   bool operator()(const DNSRecord& a, const DNSRecord& b) const;
   const SortListOrder d_slo;
 };