]> granicus.if.org Git - libevent/commitdiff
evrpc: do not check req twice
authorAzat Khuzhin <azat@libevent.org>
Sun, 31 Mar 2019 23:37:41 +0000 (02:37 +0300)
committerAzat Khuzhin <azat@libevent.org>
Sun, 31 Mar 2019 23:42:07 +0000 (02:42 +0300)
reported by µchex:
  "In evrpc.c, pointer req is dereferenced on line 881 before it is null
checked on line 894."

evrpc.c

diff --git a/evrpc.c b/evrpc.c
index 3b5260fce252ebdc0929bcb0627ba65d4197e4d8..46bf3f7e55c12f245864602a2558f01c4454762d 100644 (file)
--- a/evrpc.c
+++ b/evrpc.c
@@ -892,8 +892,7 @@ evrpc_reply_done(struct evhttp_request *req, void *arg)
                         * layer is going to free it.  we need to
                         * request ownership explicitly
                         */
-                       if (req != NULL)
-                               evhttp_request_own(req);
+                       evhttp_request_own(req);
 
                        evrpc_pause_request(pool, ctx,
                            evrpc_reply_done_closure);