]> granicus.if.org Git - esp-idf/commitdiff
fix reg operation missing
authorTian Hao <tianhao@espressif.com>
Fri, 7 Jul 2017 11:10:02 +0000 (19:10 +0800)
committerTian Hao <tianhao@espressif.com>
Fri, 7 Jul 2017 12:04:24 +0000 (20:04 +0800)
components/bt/lib
components/soc/esp32/include/soc/dport_access.h
components/soc/esp32/include/soc/soc.h

index 0f68ece75cd27b71def68b735e6a03db312a46c5..30a3ab11c441630e3e76fbf30212e546db377e8e 160000 (submodule)
@@ -1 +1 @@
-Subproject commit 0f68ece75cd27b71def68b735e6a03db312a46c5
+Subproject commit 30a3ab11c441630e3e76fbf30212e546db377e8e
index 3fc19634905f77fbf37a68c471c8b43beb353253..d1d264cbce56d7ff7783792ba56b62ca007c01a0 100644 (file)
@@ -30,7 +30,7 @@ extern "C" {
 #define _DPORT_REG_WRITE(_r, _v)   (*(volatile uint32_t *)(_r)) = (_v)
 
 //write value to register
-#define DPORT_REG_WRITE(_r, _v)   _DPORT_REG_WRITE(_r, _v)
+#define DPORT_REG_WRITE(_r, _v)   _DPORT_REG_WRITE((_r), (_v))
 
 //read value from register
 static inline uint32_t IRAM_ATTR DPORT_REG_READ(uint32_t reg)
@@ -97,7 +97,7 @@ static inline uint32_t IRAM_ATTR DPORT_READ_PERI_REG(uint32_t addr)
 }
 
 //write value to register
-#define DPORT_WRITE_PERI_REG(addr, val) _DPORT_WRITE_PERI_REG(addr, val)  
+#define DPORT_WRITE_PERI_REG(addr, val) _DPORT_WRITE_PERI_REG((addr), (val))
 
 //clear bits of register controlled by mask
 #define DPORT_CLEAR_PERI_REG_MASK(reg, mask) DPORT_WRITE_PERI_REG((reg), (DPORT_READ_PERI_REG(reg)&(~(mask))))
@@ -112,7 +112,7 @@ static inline uint32_t IRAM_ATTR DPORT_READ_PERI_REG(uint32_t addr)
 #define DPORT_GET_PERI_REG_BITS(reg, hipos,lowpos)     ((DPORT_READ_PERI_REG(reg)>>(lowpos))&((1<<((hipos)-(lowpos)+1))-1))
 
 //set bits of register controlled by mask and shift
-#define DPORT_SET_PERI_REG_BITS(reg,bit_map,value,shift) DPORT_WRITE_PERI_REG((reg),(DPORT_READ_PERI_REG(reg)&(~((bit_map)<<(shift))))|(((value) & bit_map)<<(shift)))
+#define DPORT_SET_PERI_REG_BITS(reg,bit_map,value,shift) DPORT_WRITE_PERI_REG((reg), ((DPORT_READ_PERI_REG(reg)&(~((bit_map)<<(shift))))|(((value) & bit_map)<<(shift))))
 
 //get field of register
 #define DPORT_GET_PERI_REG_BITS2(reg, mask,shift)      ((DPORT_READ_PERI_REG(reg)>>(shift))&(mask))
index 60a930a8d6652f06e38e52d719b82dd8c003d6df..70e54ded252be1642580abfd075fc5b8d4c713c2 100644 (file)
 
 //write value to register
 #define REG_WRITE(_r, _v) ({                                                                                           \
-            ASSERT_IF_DPORT_REG(_r, REG_WRITE);                                                                        \
+            ASSERT_IF_DPORT_REG((_r), REG_WRITE);                                                                      \
             (*(volatile uint32_t *)(_r)) = (_v);                                                                       \
         })
 
 //read value from register
 #define REG_READ(_r) ({                                                                                                \
             ASSERT_IF_DPORT_REG((_r), REG_READ);                                                                       \
-            (*(volatile uint32_t *)_r);                                                                                \
+            (*(volatile uint32_t *)(_r));                                                                              \
         })
 
 //get bit or get bits from register