]> granicus.if.org Git - clang/commitdiff
Rewrite-imports on crash: Simplify handling
authorDavid Blaikie <dblaikie@gmail.com>
Thu, 15 Nov 2018 03:04:19 +0000 (03:04 +0000)
committerDavid Blaikie <dblaikie@gmail.com>
Thu, 15 Nov 2018 03:04:19 +0000 (03:04 +0000)
-frewrite-imports already implies -frewrite-includes (it piggy-backs
on/extends the implementation) so there's no need to conditionally pass
-frewrite-includes when already using -frewrite-imports (& especially I
don't think these would want to be different between crash reporting and
not crash reporting)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@346927 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Driver/ToolChains/Clang.cpp

index 17b93c20986ced347a0274553d7f2886c19237c2..01525f46ba807657e41035ec320b22a4ea2d2132 100644 (file)
@@ -4916,7 +4916,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
   // nice to enable this when doing a crashdump for modules as well.
   if (Args.hasFlag(options::OPT_frewrite_includes,
                    options::OPT_fno_rewrite_includes, false) ||
-      (C.isForDiagnostics() && (RewriteImports || !HaveModules)))
+      (C.isForDiagnostics() && !HaveModules))
     CmdArgs.push_back("-frewrite-includes");
 
   // Only allow -traditional or -traditional-cpp outside in preprocessing modes.