Deprecate (unset)

Pecularily, there wasn't a single test for the (unset) cast...

diff --git a/Zend/tests/unset_cast_deprecated.phpt b/Zend/tests/unset_cast_deprecated.phpt
new file mode 100644 (file)
index 0000000..6744c85
--- /dev/null
+++ b/Zend/tests/unset_cast_deprecated.phpt
@@ -0,0 +1,14 @@
+--TEST--
+The (unset) cast is deprecated
+--FILE--
+<?php
+
+$x = 1;
+var_dump((unset) $x);
+var_dump($x);
+
+?>
+--EXPECTF--
+Deprecated: The (unset) cast is deprecated in %s on line %d
+NULL
+int(1)

diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
index 9a904eefa8e400253520cb69ae634d675fa54914..84a3e6a021299c73d82cb6db78726ca98ebd7956 100644 (file)
--- a/Zend/zend_compile.c
+++ b/Zend/zend_compile.c
@@ -6871,6 +6871,10 @@ void zend_compile_cast(znode *result, zend_ast *ast) /* {{{ */
 
        opline = zend_emit_op_tmp(result, ZEND_CAST, &expr_node, NULL);
        opline->extended_value = ast->attr;
+
+       if (ast->attr == IS_NULL) {
+               zend_error(E_DEPRECATED, "The (unset) cast is deprecated");
+       }
 }
 /* }}} */