]> granicus.if.org Git - python/commitdiff
#8594: fix ResourceWarning in test_ftplib.py - patch by Nadeem Vawda.
authorGiampaolo Rodolà <g.rodola@gmail.com>
Tue, 8 Mar 2011 20:33:21 +0000 (21:33 +0100)
committerGiampaolo Rodolà <g.rodola@gmail.com>
Tue, 8 Mar 2011 20:33:21 +0000 (21:33 +0100)
Lib/test/test_ftplib.py

index 5f8a8bde44374ec6f8476fd1d172522c496074d5..127b1b956f349703757cc920e237e3008c6b5b33 100644 (file)
@@ -619,8 +619,8 @@ class TestFTPClass(TestCase):
     def test_source_address_passive_connection(self):
         port = support.find_unused_port()
         self.client.source_address = (HOST, port)
-        sock = self.client.transfercmd('list')
-        self.assertEqual(sock.getsockname()[1], port)
+        with self.client.transfercmd('list') as sock:
+            self.assertEqual(sock.getsockname()[1], port)
 
     def test_parse257(self):
         self.assertEqual(ftplib.parse257('257 "/foo/bar"'), '/foo/bar')