bpo-30357: test_thread now uses threading_cleanup() (#1592)

test_thread: setUp() now uses support.threading_setup() and
support.threading_cleanup() to wait until threads complete to avoid
random side effects on following tests.

Co-Authored-By:  Grzegorz Grzywacz <grzegorz.grzywacz@nazwa.pl>

diff --git a/Lib/test/test_thread.py b/Lib/test/test_thread.py
index ef3059b68674b4d832dff9d38110eeee1505efe9..3909b75ccd4647d5e20de066f175227f1501cc6c 100644 (file)
--- a/Lib/test/test_thread.py
+++ b/Lib/test/test_thread.py
@@ -20,6 +20,7 @@ def verbose_print(arg):
         with _print_mutex:
             print(arg)
 
+
 class BasicThreadTest(unittest.TestCase):
 
     def setUp(self):
@@ -31,6 +32,9 @@ class BasicThreadTest(unittest.TestCase):
         self.running = 0
         self.next_ident = 0
 
+        key = support.threading_setup()
+        self.addCleanup(support.threading_cleanup, *key)
+
 
 class ThreadRunningTests(BasicThreadTest):
 

diff --git a/Misc/ACKS b/Misc/ACKS
index 0537fa4804a11919637bcb2a33e5f0f5db0cc658..246a50be00763d1edbaf2ba11a68323c703e6829 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -555,6 +555,7 @@ Eric Groo
 Daniel Andrade Groppe
 Dag Gruneau
 Filip Gruszczyński
+Grzegorz Grzywacz
 Thomas Guettler
 Yuyang Guo
 Anuj Gupta

diff --git a/Misc/NEWS b/Misc/NEWS
index 9583149a11e7fc1f5a0b2acc305088596f914037..39f583f4c4f25781be2fc9ce336829e093fb1283 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -1183,6 +1183,11 @@ Tools/Demos
 Tests
 -----
 
+* bpo-30357: test_thread: setUp() now uses support.threading_setup() and
+  support.threading_cleanup() to wait until threads complete to avoid
+  random side effects on following tests. Initial patch written by Grzegorz
+  Grzywacz.
+
 - bpo-30197: Enhanced functions swap_attr() and swap_item() in the
   test.support module.  They now work when delete replaced attribute or item
   inside the with statement.  The old value of the attribute or item (or None