Fix zlib crash from zlib.decompressobj().flush(val) when val was not positive.

It tried to allocate negative or zero memory.  That fails.

diff --git a/Lib/test/test_zlib.py b/Lib/test/test_zlib.py
index 0c96842c77a7304f4e45f9fe36570f1bf100e1a2..adb87ff0faf045b75b3ed41c38ac62f29af630c8 100644 (file)
--- a/Lib/test/test_zlib.py
+++ b/Lib/test/test_zlib.py
@@ -83,6 +83,11 @@ class ExceptionTestCase(unittest.TestCase):
         # verify failure on building decompress object with bad params
         self.assertRaises(ValueError, zlib.decompressobj, 0)
 
+    def test_decompressobj_badflush(self):
+        # verify failure on calling decompressobj.flush with bad params
+        self.assertRaises(ValueError, zlib.decompressobj().flush, 0)
+        self.assertRaises(ValueError, zlib.decompressobj().flush, -1)
+
 
 
 class CompressTestCase(unittest.TestCase):

diff --git a/Modules/zlibmodule.c b/Modules/zlibmodule.c
index f59343f298a986fe976a52d604a2dfcebfb40083..4f78dbcb15dabaf2952bee247abfc9d3127558f1 100644 (file)
--- a/Modules/zlibmodule.c
+++ b/Modules/zlibmodule.c
@@ -774,6 +774,10 @@ PyZlib_unflush(compobject *self, PyObject *args)
 
     if (!PyArg_ParseTuple(args, "|i:flush", &length))
        return NULL;
+    if (length <= 0) {
+       PyErr_SetString(PyExc_ValueError, "length must be greater than zero");
+       return NULL;
+    }
     if (!(retval = PyString_FromStringAndSize(NULL, length)))
        return NULL;