]> granicus.if.org Git - php/commitdiff
Fix handling of succeeding XFAIL tests
authorChristoph M. Becker <cmbecker69@gmx.de>
Mon, 5 Aug 2019 09:35:17 +0000 (11:35 +0200)
committerChristoph M. Becker <cmbecker69@gmx.de>
Mon, 5 Aug 2019 09:38:47 +0000 (11:38 +0200)
Due to a typo in commit e1151c9[1], succeeding XFAIL test without an
EXPECTF or EXPECTREGEX section have been reported reported as passed
instead of warned.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=e1151c9549cf5a7235c1609019f79bbb1bbcdbea>

run-tests.php

index f467b74b2520456e2b4345f9022850fa25223ffb..2104ab2a64caebb927def82f2c62d8829b82c8a2 100755 (executable)
@@ -2657,7 +2657,7 @@ COMMAND $cmd
                                if (isset($section_text['XFAIL'])) {
                                        $warn = true;
                                        $info = " (warn: XFAIL section but test passes)";
-                               } if (isset($section_text['XLEAK'])) {
+                               } elseif (isset($section_text['XLEAK'])) {
                                        $warn = true;
                                        $info = " (warn: XLEAK section but test passes)";
                 } else {