]> granicus.if.org Git - postgresql/commitdiff
Add missing assertions for required table am callbacks.
authorAmit Kapila <akapila@postgresql.org>
Sat, 6 Jul 2019 06:11:23 +0000 (11:41 +0530)
committerAmit Kapila <akapila@postgresql.org>
Sat, 6 Jul 2019 06:11:23 +0000 (11:41 +0530)
Reported-by: Ashwin Agrawal
Author: Ashwin Agrawal
Reviewed-by: Amit Kapila
Backpatch-through: 12, where it was introduced
Discussion: https://postgr.es/m/CALfoeisgdZhYDrJOukaBzvXfJOK2FQ0szVMK7dzmcy6w93iDUA@mail.gmail.com

src/backend/access/table/tableamapi.c

index b2f587681071faf020955f35d995e2f8941710f9..eff1085a6df7a0fb0651e6df87ece43cf2b37ebd 100644 (file)
@@ -51,6 +51,7 @@ GetTableAmRoutine(Oid amhandler)
        Assert(routine->scan_begin != NULL);
        Assert(routine->scan_end != NULL);
        Assert(routine->scan_rescan != NULL);
+       Assert(routine->scan_getnextslot != NULL);
 
        Assert(routine->parallelscan_estimate != NULL);
        Assert(routine->parallelscan_initialize != NULL);
@@ -62,7 +63,10 @@ GetTableAmRoutine(Oid amhandler)
        Assert(routine->index_fetch_tuple != NULL);
 
        Assert(routine->tuple_fetch_row_version != NULL);
+       Assert(routine->tuple_tid_valid != NULL);
+       Assert(routine->tuple_get_latest_tid != NULL);
        Assert(routine->tuple_satisfies_snapshot != NULL);
+       Assert(routine->compute_xid_horizon_for_tuples != NULL);
 
        Assert(routine->tuple_insert != NULL);
 
@@ -89,6 +93,7 @@ GetTableAmRoutine(Oid amhandler)
        Assert(routine->index_validate_scan != NULL);
 
        Assert(routine->relation_size != NULL);
+       Assert(routine->relation_needs_toast_table != NULL);
 
        Assert(routine->relation_estimate_size != NULL);