transfer: Fixed existing scratch buffer being checked for NULL twice

If the scratch buffer already existed when the CRLF conversion was
performed then the buffer pointer would be checked twice for NULL. This
second check is only necessary if the call to malloc() was performed by
the first check.

diff --git a/lib/transfer.c b/lib/transfer.c
index 84a7e2be44faedb6f025216717d7b232e6348e92..2cc7f78815604d4cb531a29c4bbf941a4f69add7 100644 (file)
--- a/lib/transfer.c
+++ b/lib/transfer.c
@@ -910,11 +910,12 @@ static CURLcode readwrite_upload(struct SessionHandle *data,
          (data->set.prefer_ascii) ||
 #endif
          (data->set.crlf))) {
-        if(data->state.scratch == NULL)
-          data->state.scratch = malloc(2*BUFSIZE);
         if(data->state.scratch == NULL) {
-          failf (data, "Failed to alloc scratch buffer!");
-          return CURLE_OUT_OF_MEMORY;
+          data->state.scratch = malloc(2*BUFSIZE);
+          if(data->state.scratch == NULL) {
+            failf (data, "Failed to alloc scratch buffer!");
+            return CURLE_OUT_OF_MEMORY;
+          }
         }
         /*
          * ASCII/EBCDIC Note: This is presumably a text (not binary)