Merged revisions 86090 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86090 | steven.bethard | 2010-11-01 16:57:36 +0100 (Mon, 01 Nov 2010) | 1 line

  Fix bug 9352 where characters were being lost in parsing some short options
........

diff --git a/Lib/argparse.py b/Lib/argparse.py
index d5bc16c6b148915d09a2632ee7c94daa732b3433..9597a671fadd98553a0f66fbaf7b3208d51eaf4d 100644 (file)
--- a/Lib/argparse.py
+++ b/Lib/argparse.py
@@ -1796,13 +1796,13 @@ class ArgumentParser(_AttributeHolder, _ActionsContainer):
                     chars = self.prefix_chars
                     if arg_count == 0 and option_string[1] not in chars:
                         action_tuples.append((action, [], option_string))
-                        for char in self.prefix_chars:
-                            option_string = char + explicit_arg[0]
-                            explicit_arg = explicit_arg[1:] or None
-                            optionals_map = self._option_string_actions
-                            if option_string in optionals_map:
-                                action = optionals_map[option_string]
-                                break
+                        char = option_string[0]
+                        option_string = char + explicit_arg[0]
+                        new_explicit_arg = explicit_arg[1:] or None
+                        optionals_map = self._option_string_actions
+                        if option_string in optionals_map:
+                            action = optionals_map[option_string]
+                            explicit_arg = new_explicit_arg
                         else:
                             msg = _('ignored explicit argument %r')
                             raise ArgumentError(action, msg % explicit_arg)

diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py
index 349de7b8170f5cd46abdaa23fd4eece26d1ceb07..9fd8c02822b3fc078b3f7f10be00b1528d3a9288 100644 (file)
--- a/Lib/test/test_argparse.py
+++ b/Lib/test/test_argparse.py
@@ -468,6 +468,30 @@ class TestOptionalsAlternatePrefixCharsAddedHelp(ParserTestCase):
         ('/ba +f', NS(f=True, bar=None, baz=42))
     ]
 
+
+class TestOptionalsAlternatePrefixCharsMultipleShortArgs(ParserTestCase):
+    """Verify that Optionals must be called with their defined prefixes"""
+
+    parser_signature = Sig(prefix_chars='+-', add_help=False)
+    argument_signatures = [
+        Sig('-x', action='store_true'),
+        Sig('+y', action='store_true'),
+        Sig('+z', action='store_true'),
+    ]
+    failures = ['-w',
+                '-xyz',
+                '+x',
+                '-y',
+                '+xyz',
+    ]
+    successes = [
+        ('', NS(x=False, y=False, z=False)),
+        ('-x', NS(x=True, y=False, z=False)),
+        ('+y -x', NS(x=True, y=True, z=False)),
+        ('+yz -x', NS(x=True, y=True, z=True)),
+    ]
+
+
 class TestOptionalsShortLong(ParserTestCase):
     """Test a combination of single- and double-dash option strings"""