Add cppcheck target to run cppcheck on all source files.

diff --git a/Makefile.in b/Makefile.in
index d8a79811ccc9ddfe4fd003941a9dfb04c9b1f816..ff47a22f2035d9cc87f9e63240ba6ccb184b1302 100644 (file)
--- a/Makefile.in
+++ b/Makefile.in
@@ -78,39 +78,50 @@ XGETTEXT_OPTS = -F -k_ -kN_ -kU_ --copyright-holder="Todd C. Miller" \
                --flag easprintf:3:c-format --flag lbuf_append:2:c-format \
                --flag lbuf_append_quoted:3:c-format --foreign-user
 
+# Default cppcheck options when run from the top-level Makefile
+CPPCHECK_OPTS = -q --force --enable=warning,performance,portability --suppress=constStatement --error-exitcode=1 --inline-suppr -U__cplusplus -UQUAD_MAX -UQUAD_MIN -UUQUAD_MAX -U_POSIX_HOST_NAME_MAX -U_POSIX_PATH_MAX
+
 all: config.status
-       for d in $(SUBDIRS); \
-           do (cd $$d && exec $(MAKE) $@) && continue; \
+       for d in $(SUBDIRS); do \
+           (cd $$d && exec $(MAKE) $@) && continue; \
            exit $$?; \
        done
 
 check pre-install: config.status
-       for d in $(SUBDIRS); \
-           do (cd $$d && exec $(MAKE) $@) && continue; \
+       for d in $(SUBDIRS); do \
+           (cd $$d && exec $(MAKE) $@) && continue; \
            exit $$?; \
        done
 
+cppcheck: config.status
+       rval=0; \
+       for d in $(SUBDIRS); do \
+           echo checking $$d; \
+           (cd $$d && exec $(MAKE) CPPCHECK_OPTS="$(CPPCHECK_OPTS)" $@) || rval=`expr $$rval + $$?`; \
+       done; \
+       exit $$rval
+
 install-dirs install-binaries install-includes install-plugin: config.status pre-install
-       for d in $(SUBDIRS); \
-           do (cd $$d && exec $(MAKE) $@) && continue; \
+       for d in $(SUBDIRS); do \
+           (cd $$d && exec $(MAKE) $@) && continue; \
            exit $$?; \
        done
 
 install-doc: config.status ChangeLog
-       for d in $(SUBDIRS); \
-           do (cd $$d && exec $(MAKE) $@) && continue; \
+       for d in $(SUBDIRS); do \
+           (cd $$d && exec $(MAKE) $@) && continue; \
            exit $$?; \
        done
 
 install: config.status ChangeLog pre-install install-nls
-       for d in $(SUBDIRS); \
-           do (cd $$d && exec $(MAKE) $@) && continue; \
+       for d in $(SUBDIRS); do \
+           (cd $$d && exec $(MAKE) $@) && continue; \
            exit $$?; \
        done
 
 uninstall: uninstall-nls
-       for d in $(SUBDIRS); \
-           do (cd $$d && exec $(MAKE) $@) && continue; \
+       for d in $(SUBDIRS); do \
+           (cd $$d && exec $(MAKE) $@) && continue; \
            exit $$?; \
        done
 

diff --git a/common/Makefile.in b/common/Makefile.in
index aed7b5f97752a612313e72b9426b3d022bb2a9f3..98fb05908510cab713c3993cccd95779dca980ad 100644 (file)
--- a/common/Makefile.in
+++ b/common/Makefile.in
@@ -54,6 +54,9 @@ PIE_LDFLAGS = @PIE_LDFLAGS@
 SSP_CFLAGS = @SSP_CFLAGS@
 SSP_LDFLAGS = @SSP_LDFLAGS@
 
+# cppcheck options, usually set in the top-level Makefile
+CPPCHECK_OPTS = -q --force --enable=warning,performance,portability --suppress=constStatement --error-exitcode=1 --inline-suppr -U__cplusplus -UQUAD_MAX -UQUAD_MIN -UUQUAD_MAX -U_POSIX_HOST_NAME_MAX -U_POSIX_PATH_MAX
+
 # Regression tests
 TEST_PROGS = conf_test parseln_test hltq_test
 TEST_LIBS = @LIBS@ @LIBINTL@ ../compat/libreplace.la
@@ -115,6 +118,9 @@ install-plugin:
 
 uninstall:
 
+cppcheck:
+       cppcheck $(CPPCHECK_OPTS) -I$(incdir) -I$(top_builddir) -I$(top_srcdir) $(srcdir)/*.c
+
 check: $(TEST_PROGS)
        @if test X"$(cross_compiling)" != X"yes"; then \
            passed=0; failed=0; total=0; \

diff --git a/compat/Makefile.in b/compat/Makefile.in
index 843200e38c559f75f02d10e1f9ffdb95c8dc0df6..38d4371c6f43c3b348ef79936b49d1c6f4c20362 100644 (file)
--- a/compat/Makefile.in
+++ b/compat/Makefile.in
@@ -54,6 +54,9 @@ PIE_LDFLAGS = @PIE_LDFLAGS@
 SSP_CFLAGS = @SSP_CFLAGS@
 SSP_LDFLAGS = @SSP_LDFLAGS@
 
+# cppcheck options, usually set in the top-level Makefile
+CPPCHECK_OPTS = -q --force --enable=warning,performance,portability --suppress=constStatement --error-exitcode=1 --inline-suppr -U__cplusplus -UQUAD_MAX -UQUAD_MIN -UUQUAD_MAX -U_POSIX_HOST_NAME_MAX -U_POSIX_PATH_MAX
+
 # OS dependent defines
 DEFS = @OSDEFS@
 
@@ -130,6 +133,9 @@ install-plugin:
 
 uninstall:
 
+cppcheck:
+       cppcheck $(CPPCHECK_OPTS) -I$(incdir) -I$(top_builddir) -I$(top_srcdir) $(srcdir)/*.c
+
 check: $(TEST_PROGS)
        @if test X"$(cross_compiling)" != X"yes"; then \
            if test -f fnm_test; then \

diff --git a/doc/Makefile.in b/doc/Makefile.in
index 5ed4f014440f87963fc4a20c513a155732f1f1bc..1f6b51a1226dfae4f41fed5dc322997e32d3600a 100644 (file)
--- a/doc/Makefile.in
+++ b/doc/Makefile.in
@@ -343,6 +343,8 @@ uninstall:
                $(DESTDIR)$(mandirform)/sudoers.$(mansectform) \
                $(DESTDIR)$(mandirform)/sudoers.ldap.$(mansectform)
 
+cppcheck:
+
 check:
 
 clean:

diff --git a/include/Makefile.in b/include/Makefile.in
index 42058ddfa3c3cad84a93a193dd64b4b2ae1e6151..e48620f3f66f86974cff0e72b2f1eb3173f3262d 100644 (file)
--- a/include/Makefile.in
+++ b/include/Makefile.in
@@ -72,6 +72,8 @@ install-plugin:
 uninstall:
        -rm -f $(DESTDIR)$(includedir)/sudo_plugin.h
 
+cppcheck:
+
 check:
 
 clean:

diff --git a/plugins/group_file/Makefile.in b/plugins/group_file/Makefile.in
index 8370d48db4bea311a5aa250b0ea021235ae50934..894daf8c27b07ce739b7c2cfebf17a32220b90c5 100644 (file)
--- a/plugins/group_file/Makefile.in
+++ b/plugins/group_file/Makefile.in
@@ -55,6 +55,9 @@ PIE_LDFLAGS = @PIE_LDFLAGS@
 SSP_CFLAGS = @SSP_CFLAGS@
 SSP_LDFLAGS = @SSP_LDFLAGS@
 
+# cppcheck options, usually set in the top-level Makefile
+CPPCHECK_OPTS = -q --force --enable=warning,performance,portability --suppress=constStatement --error-exitcode=1 --inline-suppr -U__cplusplus -UQUAD_MAX -UQUAD_MIN -UUQUAD_MAX -U_POSIX_HOST_NAME_MAX -U_POSIX_PATH_MAX
+
 # Where to install things...
 prefix = @prefix@
 exec_prefix = @exec_prefix@
@@ -126,6 +129,9 @@ install-plugin: install-dirs group_file.la
 uninstall:
        -rm -f $(DESTDIR)$(plugindir)/group_file.so
 
+cppcheck:
+       cppcheck $(CPPCHECK_OPTS) -I$(incdir) -I$(top_builddir) -I$(top_srcdir) $(srcdir)/*.c
+
 check:
 
 clean:

diff --git a/plugins/sample/Makefile.in b/plugins/sample/Makefile.in
index 37f7e5c08f6390af13239e6a8ca7eb22aa3ff151..24265b6cbd48e7137930804756acb0045eeafd3d 100644 (file)
--- a/plugins/sample/Makefile.in
+++ b/plugins/sample/Makefile.in
@@ -54,6 +54,9 @@ PIE_LDFLAGS = @PIE_LDFLAGS@
 SSP_CFLAGS = @SSP_CFLAGS@
 SSP_LDFLAGS = @SSP_LDFLAGS@
 
+# cppcheck options, usually set in the top-level Makefile
+CPPCHECK_OPTS = -q --force --enable=warning,performance,portability --suppress=constStatement --error-exitcode=1 --inline-suppr -U__cplusplus -UQUAD_MAX -UQUAD_MIN -UUQUAD_MAX -U_POSIX_HOST_NAME_MAX -U_POSIX_PATH_MAX
+
 # Where to install things...
 prefix = @prefix@
 exec_prefix = @exec_prefix@
@@ -125,6 +128,9 @@ install-plugin: install-dirs sample_plugin.la
 uninstall:
        -rm -f $(DESTDIR)$(plugindir)/sample_plugin.so
 
+cppcheck:
+       cppcheck $(CPPCHECK_OPTS) -I$(incdir) -I$(top_builddir) -I$(top_srcdir) $(srcdir)/*.c
+
 check:
 
 clean:

diff --git a/plugins/sudoers/Makefile.in b/plugins/sudoers/Makefile.in
index 5a7c653e1643a8651c2ad0fd11b0324e87f7accf..b4c4965c1f949734c9442b7f02617e170cc172d9 100644 (file)
--- a/plugins/sudoers/Makefile.in
+++ b/plugins/sudoers/Makefile.in
@@ -70,6 +70,9 @@ PIE_LDFLAGS = @PIE_LDFLAGS@
 SSP_CFLAGS = @SSP_CFLAGS@
 SSP_LDFLAGS = @SSP_LDFLAGS@
 
+# cppcheck options, usually set in the top-level Makefile
+CPPCHECK_OPTS = -q --force --enable=warning,performance,portability --suppress=constStatement --error-exitcode=1 --inline-suppr -U__cplusplus -UQUAD_MAX -UQUAD_MIN -UUQUAD_MAX -U_POSIX_HOST_NAME_MAX -U_POSIX_PATH_MAX
+
 # Where to install things...
 prefix = @prefix@
 exec_prefix = @exec_prefix@
@@ -318,6 +321,9 @@ uninstall:
        -cmp $(DESTDIR)$(sudoersdir)/sudoers $(srcdir)/sudoers >/dev/null && \
            rm -f $(DESTDIR)$(sudoersdir)/sudoers
 
+cppcheck:
+       cppcheck $(CPPCHECK_OPTS) -I$(incdir) -I$(top_builddir) -I$(devdir) -I$(srcdir) -I$(top_srcdir) $(srcdir)/*.c $(srcdir)/auth/*.c
+
 check: $(TEST_PROGS) visudo testsudoers
        @if test X"$(cross_compiling)" != X"yes"; then \
            rval=0; \

diff --git a/plugins/system_group/Makefile.in b/plugins/system_group/Makefile.in
index 0ab968c4da5d48339c40ffb0ed31186182221644..0d7440984d6ec88f214165323da6db97cdffa67c 100644 (file)
--- a/plugins/system_group/Makefile.in
+++ b/plugins/system_group/Makefile.in
@@ -55,6 +55,9 @@ PIE_LDFLAGS = @PIE_LDFLAGS@
 SSP_CFLAGS = @SSP_CFLAGS@
 SSP_LDFLAGS = @SSP_LDFLAGS@
 
+# cppcheck options, usually set in the top-level Makefile
+CPPCHECK_OPTS = -q --force --enable=warning,performance,portability --suppress=constStatement --error-exitcode=1 --inline-suppr -U__cplusplus -UQUAD_MAX -UQUAD_MIN -UUQUAD_MAX -U_POSIX_HOST_NAME_MAX -U_POSIX_PATH_MAX
+
 # Where to install things...
 prefix = @prefix@
 exec_prefix = @exec_prefix@
@@ -126,6 +129,9 @@ install-plugin: install-dirs system_group.la
 uninstall:
        -rm -f $(DESTDIR)$(plugindir)/system_group.so
 
+cppcheck:
+       cppcheck $(CPPCHECK_OPTS) -I$(incdir) -I$(top_builddir) -I$(top_srcdir) $(srcdir)/*.c
+
 check:
 
 clean:

diff --git a/src/Makefile.in b/src/Makefile.in
index d418971a6d5701856232bf0c8ac7e0a9bf619dc1..83c8a2e4a3d19528598b0d0ce9778b840eb346e5 100644 (file)
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -55,6 +55,9 @@ PIE_LDFLAGS = @PIE_LDFLAGS@
 SSP_CFLAGS = @SSP_CFLAGS@
 SSP_LDFLAGS = @SSP_LDFLAGS@
 
+# cppcheck options, usually set in the top-level Makefile
+CPPCHECK_OPTS = -q --force --enable=warning,performance,portability --suppress=constStatement --error-exitcode=1 --inline-suppr -U__cplusplus -UQUAD_MAX -UQUAD_MIN -UUQUAD_MAX -U_POSIX_HOST_NAME_MAX -U_POSIX_PATH_MAX
+
 # Where to install things...
 prefix = @prefix@
 exec_prefix = @exec_prefix@
@@ -160,6 +163,9 @@ uninstall:
                $(DESTDIR)$(libexecdir)/sudo/sesh \
                $(DESTDIR)$(noexecdir)/$(noexecfile)
 
+cppcheck:
+       cppcheck $(CPPCHECK_OPTS) -I$(incdir) -I$(top_builddir) -I. -I$(srcdir) -I$(top_srcdir) $(srcdir)/*.c
+
 check: $(TEST_PROGS)
        ./check_ttyname
 

diff --git a/zlib/Makefile.in b/zlib/Makefile.in
index ab2342c36968549745ffaf9dc723209fec95b430..6a8673c2527e792993e9abcad39051fe7df6cba4 100644 (file)
--- a/zlib/Makefile.in
+++ b/zlib/Makefile.in
@@ -74,6 +74,8 @@ install-plugin:
 
 uninstall:
 
+cppcheck:
+
 check:
 
 clean: