Fix failure with pgperlcritic from the TAP test of synchronous replication

Oversight in 7d81bdc, which introduced a new routine in perl lacking a
return clause.  Per buildfarm member crake.

Backpatch down to 9.6 like its parent.

Reported-by: Andrew Dunstan
Discussion: https://postgr.es/m/16da29fa-d504-1380-7095-40de586dc038@2ndQuadrant.com
Backpatch-through: 9.6

diff --git a/src/test/recovery/t/007_sync_rep.pl b/src/test/recovery/t/007_sync_rep.pl
index c88430fb270ffea2d6d435ac80de864eaa88928f..5d9bd504e4aa07351b4854a76b01279dbefbe03f 100644 (file)
--- a/src/test/recovery/t/007_sync_rep.pl
+++ b/src/test/recovery/t/007_sync_rep.pl
@@ -58,6 +58,7 @@ sub start_standby_and_wait
 
        print("### Waiting for standby \"$standby_name\" on \"$master_name\"\n");
        $master->poll_query_until('postgres', $query);
+       return;
 }
 
 # Initialize master node