github issue #481 - highlighting for #overview

Report states that the dungeon overview menu doesn't honor the
'menu_headings' option.  However, dungeon overview is not a menu.

Despite that, switch its hardcoded use of bold and inverse to use
the option value instead.  It doesn't really need two different
highlights and this allows user to control which video attribute
gets used.  If someone wants different highlighting for overview
than for menus, they're out of luck.

Fixes #481

diff --git a/doc/fixes37.0 b/doc/fixes37.0
index 0db05901e2e3a6a5e40e4ff6ac79a884125b04dc..65f224a9f89093e15087e396e35bdf3ec6414262 100644 (file)
--- a/doc/fixes37.0
+++ b/doc/fixes37.0
@@ -436,6 +436,8 @@ attempt to make corpse or statue of a named player character would yield that
 homemade tin of very low nutrition corpse gave more nutrition than the corpse
 magic mapping performed while engulfed or underwater would display whole map
        but then not switch back to the engulfed or underwater restricted view
+#overview used hardcoded bold and inverse for highlighting; switch to the
+       'menu_headings' option value so player has some control
 
 
 Fixes to 3.7.0-x Problems that Were Exposed Via git Repository

diff --git a/src/dungeon.c b/src/dungeon.c
index f1953448490a8fafe83eb1ac81e3764794a2bbd6..427ec44fa7d5bc13e2625929364015e733ddb391 100644 (file)
--- a/src/dungeon.c
+++ b/src/dungeon.c
@@ -3257,7 +3257,7 @@ print_mapseen(winid win, mapseen *mptr,
             Sprintf(buf, "%s: levels %d to %d",
                     g.dungeons[dnum].dname, depthstart,
                     depthstart + g.dungeons[dnum].dunlev_ureached - 1);
-        putstr(win, !final ? ATR_INVERSE : 0, buf);
+        putstr(win, !final ? iflags.menu_headings : 0, buf);
     }
 
     /* calculate level number */
@@ -3282,7 +3282,7 @@ print_mapseen(winid win, mapseen *mptr,
                 (!final || (final == 1 && how == ASCENDED)) ? "are"
                   : (final == 1 && how == ESCAPED) ? "left from"
                     : "were");
-    putstr(win, !final ? ATR_BOLD : 0, buf);
+    putstr(win, !final ? iflags.menu_headings : 0, buf);
 
     if (mptr->flags.forgot)
         return;