]> granicus.if.org Git - clang/commitdiff
Put warn_logical_and_in_logical_or warning in new warning group "logical-op-parenthes...
authorArgyrios Kyrtzidis <akyrtzi@gmail.com>
Wed, 17 Nov 2010 18:26:33 +0000 (18:26 +0000)
committerArgyrios Kyrtzidis <akyrtzi@gmail.com>
Wed, 17 Nov 2010 18:26:33 +0000 (18:26 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@119532 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td

index c89ab09b3af74657a1169a1fc75ccda6cf948922..7fb14705df997914903ad4a948a5445b4459c8be 100644 (file)
@@ -54,6 +54,7 @@ def : DiagGroup<"effc++">;
 def FourByteMultiChar : DiagGroup<"four-char-constants">;
 def GlobalConstructors : DiagGroup<"global-constructors">;
 def : DiagGroup<"idiomatic-parentheses">;
+def LogicalOpParentheses: DiagGroup<"logical-op-parentheses">;
 def IgnoredQualifiers : DiagGroup<"ignored-qualifiers">;
 def : DiagGroup<"import">;
 def : DiagGroup<"init-self">;
@@ -162,7 +163,9 @@ def CharSubscript : DiagGroup<"char-subscripts">;
 
 // -Widiomatic-parentheses contains warnings about 'idiomatic'
 // missing parentheses;  it is off by default.
-def Parentheses : DiagGroup<"parentheses", [DiagGroup<"idiomatic-parentheses">]>;
+def Parentheses : DiagGroup<"parentheses",
+                            [LogicalOpParentheses,
+                             DiagGroup<"idiomatic-parentheses">]>;
 
 // -Wconversion has its own warnings, but we split a few out for
 // legacy reasons:
index 4c8325621fb1f54917791ac466205116c3321677..277653e7ea17dd41b4b98f1ac5ec39f1cf7f77cb 100644 (file)
@@ -2158,7 +2158,7 @@ def warn_logical_instead_of_bitwise : Warning<
   "remove constant">, InGroup<DiagGroup<"constant-logical-operand">>;
 
 def warn_logical_and_in_logical_or : Warning<
-  "'&&' within '||'">, InGroup<Parentheses>;
+  "'&&' within '||'">, InGroup<LogicalOpParentheses>;
 def note_logical_and_in_logical_or_silence : Note<
   "place parentheses around the '&&' expression to silence this warning">;