]> granicus.if.org Git - clang/commitdiff
Try to eliminate GCC_CAST hack in a manner that should work for both
authorDouglas Gregor <dgregor@apple.com>
Tue, 17 Jul 2012 21:27:49 +0000 (21:27 +0000)
committerDouglas Gregor <dgregor@apple.com>
Tue, 17 Jul 2012 21:27:49 +0000 (21:27 +0000)
GCC and MSVC.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@160397 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/AST/RecursiveASTVisitor.h

index 2e56a486f3d0bb2432b21fa04ddb5296d54a12cc..fa272ffdc24a73afa051a8dcf6625a090ab4557d 100644 (file)
@@ -464,19 +464,11 @@ template<typename Derived>
 bool RecursiveASTVisitor<Derived>::dataTraverseNode(Stmt *S,
                                                     bool &EnqueueChildren) {
 
-// The cast for DISPATCH_WALK is needed for older versions of g++, but causes
-// problems for MSVC.  So we'll skip the cast entirely for MSVC.
-#if defined(_MSC_VER)
-  #define GCC_CAST(CLASS)
-#else
-  #define GCC_CAST(CLASS) (bool (RecursiveASTVisitor::*)(CLASS*))
-#endif
-
   // Dispatch to the corresponding WalkUpFrom* function only if the derived
   // class didn't override Traverse* (and thus the traversal is trivial).
 #define DISPATCH_WALK(NAME, CLASS, VAR) \
-  if (&RecursiveASTVisitor::Traverse##NAME == \
-      GCC_CAST(CLASS)&Derived::Traverse##NAME) \
+  if ((bool (Derived::*)(CLASS*))&RecursiveASTVisitor::Traverse##NAME == \
+      &Derived::Traverse##NAME) \
     return getDerived().WalkUpFrom##NAME(static_cast<CLASS*>(VAR)); \
   EnqueueChildren = false; \
   return getDerived().Traverse##NAME(static_cast<CLASS*>(VAR));
@@ -516,7 +508,6 @@ bool RecursiveASTVisitor<Derived>::dataTraverseNode(Stmt *S,
   }
 
 #undef DISPATCH_WALK
-#undef GCC_CAST
 
   return true;
 }