IndexOptInfo *index = (IndexOptInfo *) lfirst(lc);
/* Protect limited-size array in IndexClauseSets */
- Assert(index->ncolumns <= INDEX_MAX_KEYS);
+ Assert(index->nkeycolumns <= INDEX_MAX_KEYS);
/*
* Ignore partial indexes that do not match the query.
* relation itself is also included in the relids set. considered_relids
* lists all relids sets we've already tried.
*/
- for (indexcol = 0; indexcol < index->ncolumns; indexcol++)
+ for (indexcol = 0; indexcol < index->nkeycolumns; indexcol++)
{
/* Consider each applicable simple join clause */
considered_clauses += list_length(jclauseset->indexclauses[indexcol]);
/* Identify indexclauses usable with this relids set */
MemSet(&clauseset, 0, sizeof(clauseset));
- for (indexcol = 0; indexcol < index->ncolumns; indexcol++)
+ for (indexcol = 0; indexcol < index->nkeycolumns; indexcol++)
{
ListCell *lc;
index_clauses = NIL;
found_lower_saop_clause = false;
outer_relids = bms_copy(rel->lateral_relids);
- for (indexcol = 0; indexcol < index->ncolumns; indexcol++)
+ for (indexcol = 0; indexcol < index->nkeycolumns; indexcol++)
{
ListCell *lc;
/*
* We allow any column of the index to match each pathkey; they
* don't have to match left-to-right as you might expect. This is
- * correct for GiST, which is the sole existing AM supporting
- * amcanorderbyop. We might need different logic in future for
- * other implementations.
+ * correct for GiST, and it doesn't matter for SP-GiST because
+ * that doesn't handle multiple columns anyway, and no other
+ * existing AMs support amcanorderbyop. We might need different
+ * logic in future for other implementations.
*/
- for (indexcol = 0; indexcol < index->ncolumns; indexcol++)
+ for (indexcol = 0; indexcol < index->nkeycolumns; indexcol++)
{
Expr *expr;
* Try to find each index column in the lists of conditions. This is
* O(N^2) or worse, but we expect all the lists to be short.
*/
- for (c = 0; c < ind->ncolumns; c++)
+ for (c = 0; c < ind->nkeycolumns; c++)
{
bool matched = false;
ListCell *lc;
break; /* no match; this index doesn't help us */
}
- /* Matched all columns of this index? */
- if (c == ind->ncolumns)
+ /* Matched all key columns of this index? */
+ if (c == ind->nkeycolumns)
return true;
}
* it to expressional index columns, in hopes of finding some
* statistics.
*
+ * Note that we consider all index columns including INCLUDE columns,
+ * since there could be stats for such columns. But the test for
+ * uniqueness needs to be warier.
+ *
* XXX it's conceivable that there are multiple matches with different
* index opfamilies; if so, we need to pick one that matches the
* operator we are estimating for. FIXME later.
*/
if (index->unique &&
index->nkeycolumns == 1 &&
+ pos == 0 &&
(index->indpred == NIL || index->predOK))
vardata->isunique = true;
if (index->reverse_sort[0])
varCorrelation = -varCorrelation;
- if (index->ncolumns > 1)
+ if (index->nkeycolumns > 1)
costs.indexCorrelation = varCorrelation * 0.75;
else
costs.indexCorrelation = varCorrelation;