Closes #13661: Check added for type of logger name.

diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py
index f6af6057e6c2b1e133e585e419b4b6536a8925d3..a0c4cb7233c82327a75f4877176356304c982175 100644 (file)
--- a/Lib/logging/__init__.py
+++ b/Lib/logging/__init__.py
@@ -1007,6 +1007,8 @@ class Manager(object):
         placeholder to now point to the logger.
         """
         rv = None
+        if not isinstance(name, basestring):
+            raise ValueError('A logger name must be string or Unicode')
         if isinstance(name, unicode):
             name = name.encode('utf-8')
         _acquireLock()

diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 0760a6a07b221a7f86241987725bf2fee3fae873..b2d0a2bda62301cc64f7c07f6f8162c0c632ff10 100644 (file)
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -272,6 +272,8 @@ class BuiltinLevelsTest(BaseTest):
             ('INF.BADPARENT', 'INFO', '4'),
         ])
 
+    def test_invalid_name(self):
+        self.assertRaises(ValueError, logging.getLogger, any)
 
 class BasicFilterTest(BaseTest):