Remove most Elixir warnings

diff --git a/lib/ejabberd/config/config.ex b/lib/ejabberd/config/config.ex
index 4d1270bc17546003f04c26d783ebb0f2ea955305..4d1728d1643f7637247178733d36a166aa8d4efe 100644 (file)
--- a/lib/ejabberd/config/config.ex
+++ b/lib/ejabberd/config/config.ex
@@ -23,7 +23,7 @@ defmodule Ejabberd.Config do
   # Could be also possible to interrupt the compilation&execution by throwing
   # an exception if necessary.
   def __before_compile__(_env) do
-    get_modules_parsed_in_order
+    get_modules_parsed_in_order()
     |> EjabberdModule.validate
     |> EjabberdLogger.log_errors
   end
@@ -48,7 +48,7 @@ defmodule Ejabberd.Config do
   Returns a list with all the opts, formatted for ejabberd.
   """
   def get_ejabberd_opts do
-    get_general_opts
+    get_general_opts()
     |> Dict.put(:modules, get_modules_parsed_in_order())
     |> Dict.put(:listeners, get_listeners_parsed_in_order())
     |> Ejabberd.Config.OptsFormatter.format_opts_for_ejabberd

diff --git a/lib/ejabberd/config/ejabberd_module.ex b/lib/ejabberd/config/ejabberd_module.ex
index 4de9a302efa49fe5f41f5a2c3333e94e80463d24..6a74fe4602fa7387110171b1ec3e0e2dd2f7ca6d 100644 (file)
--- a/lib/ejabberd/config/ejabberd_module.ex
+++ b/lib/ejabberd/config/ejabberd_module.ex
@@ -12,7 +12,6 @@ defmodule Ejabberd.Config.EjabberdModule do
   defstruct [:module, :attrs]
 
   alias Ejabberd.Config.EjabberdModule
-  alias Ejabberd.Config.Attr
   alias Ejabberd.Config.Validation
 
   @doc """

diff --git a/lib/ejabberd/config/logger/ejabberd_logger.ex b/lib/ejabberd/config/logger/ejabberd_logger.ex
index 270fbfaa6a2d4b12c0919b0da81bcfff8d975c12..90970ba73948baa37acfc1140cb83fa83aac9145 100644 (file)
--- a/lib/ejabberd/config/logger/ejabberd_logger.ex
+++ b/lib/ejabberd/config/logger/ejabberd_logger.ex
@@ -21,7 +21,7 @@ defmodule Ejabberd.Config.EjabberdLogger do
   defp do_log_errors({:attribute, errors}), do: Enum.each errors, &log_attribute_error/1
   defp do_log_errors({:dependency, errors}), do: Enum.each errors, &log_dependency_error/1
 
-  defp log_attribute_error({{attr_name, val}, :attr_not_supported}), do:
+  defp log_attribute_error({{attr_name, _val}, :attr_not_supported}), do:
     IO.puts "[ WARN ] Annotation @#{attr_name} is not supported."
 
   defp log_attribute_error({{attr_name, val}, :type_not_supported}), do:

diff --git a/lib/ejabberd/config/validator/validation.ex b/lib/ejabberd/config/validator/validation.ex
index 2fe00361af89037b510f76772a8cb91a6ec2a620..af582676ece896cd6db18a5006b0206410c1f8be 100644 (file)
--- a/lib/ejabberd/config/validator/validation.ex
+++ b/lib/ejabberd/config/validator/validation.ex
@@ -7,9 +7,7 @@ defmodule Ejabberd.Config.Validation do
   @type mod_validation_result :: {:ok, EjabberdModule.t} | {:error, EjabberdModule.t, map}
 
   alias Ejabberd.Config.EjabberdModule
-  alias Ejabberd.Config.Attr
   alias Ejabberd.Config.Validator
-  alias Ejabberd.Config.ValidatorUtility
 
   @doc """
   Given a module or a list of modules it runs validators on them

diff --git a/lib/ejabberd/config/validator/validator_attrs.ex b/lib/ejabberd/config/validator/validator_attrs.ex
index 94117ab21daa9a5bc1ca935c062c7970230fc62c..6a85c068dedcfc2b71aa7bb6588069b47e8008ee 100644 (file)
--- a/lib/ejabberd/config/validator/validator_attrs.ex
+++ b/lib/ejabberd/config/validator/validator_attrs.ex
@@ -18,7 +18,7 @@ defmodule Ejabberd.Config.Validator.Attrs do
   def validate({modules, mod, errors}) do
     errors = Enum.reduce mod.attrs, errors, fn(attr, err) ->
       case Attr.validate(attr) do
-        {:ok, attr} -> err
+        {:ok, _attr} -> err
         {:error, attr, cause} -> put_error(err, :attribute, {attr, cause})
       end
     end

diff --git a/lib/mix/tasks/deps.tree.ex b/lib/mix/tasks/deps.tree.ex
index 94cb85a50500ad497225e2f61b981f06ecdd8301..50189c3d2c7b95714a96587e9814cb26b649696f 100644 (file)
--- a/lib/mix/tasks/deps.tree.ex
+++ b/lib/mix/tasks/deps.tree.ex
@@ -40,7 +40,7 @@ defmodule Mix.Tasks.Ejabberd.Deps.Tree do
     end
   end
 
-  defp build_dependency_tree(mods, mod, []), do: %{module: mod, dependency: []}
+  defp build_dependency_tree(_mods, mod, []), do: %{module: mod, dependency: []}
   defp build_dependency_tree(mods, mod, deps) when is_list(deps) do
     dependencies = Enum.map deps, fn dep ->
       dep_deps = get_dependencies_of_mod(mods, dep)
@@ -65,7 +65,7 @@ defmodule Mix.Tasks.Ejabberd.Deps.Tree do
 
   defp keep_only_mods_not_used_as_dep(mods, mods_used_as_dep) do
     Enum.filter mods, fn %{module: mod} ->
-      not mod in mods_used_as_dep
+      mod not in mods_used_as_dep
     end
   end
 

diff --git a/lib/mod_presence_demo.ex b/lib/mod_presence_demo.ex
index 09bf584057a1cfd24f11b14bbd2bd32c6e459061..3ce512c3dfc2a9e238361bc8150945fcb7ecde2d 100644 (file)
--- a/lib/mod_presence_demo.ex
+++ b/lib/mod_presence_demo.ex
@@ -17,4 +17,13 @@ defmodule ModPresenceDemo do
     info('Receive presence for #{user}')
     :none
   end
+
+  def depends(_host, _opts) do
+    []
+  end
+
+  def mod_options(_host) do
+    []
+  end
+  
 end